don't throw an exception when canceling playbook if play execution was already completed #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s already completed In some cases play execution is completed, but host deploy process is still running and parsing events. In such case if the timeout was reached, an attempt to cancel the playbook will fail because the play process no longer exists. In cases where the command to cancel the playbook fails, an error will be logged with both host-deploy and stdout logs. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=2087738
dangel101
requested review from
mwperina,
ahadas,
bennyz,
emesika,
michalskrivanek,
oliel,
sgratch and
didib
as code owners
mwperina
requested changes
Jun 6, 2022
| // if play execution was already completed, the command fails. | ||
| } catch (IOException e) { | ||
| log.error(String.format("Failed to execute call to cancel playbook. %1$s, %2$s ", | ||
| output.toString(), Paths.get(this.getJobEventsDir(uuid.toString()) + "../stdout"))); |
There was a problem hiding this comment.
Please reformat to make more readable and add full stacktrace to debug log:
log.error(String.format("Failed to execute call to cancel playbook. %1$s, %2$s../stdout ",
output.toString(),
Paths.get(this.getJobEventsDir(uuid.toString()))));
log.debug("Exception:", e);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases play execution is completed, but host deploy process is still running and parsing events.
In such case if the timeout was reached, an attempt to cancel the playbook will fail because the play process
no longer exists.
In cases where the command to cancel the playbook fails, an error will be logged with both host-deploy and
stdout logs.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=2087738