Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove network-scripts-openvswitch 2.11 package before upgrading packages #413

Merged
merged 4 commits into from
Jun 8, 2022

Conversation

dangel101
Copy link
Member

@dangel101 dangel101 requested a review from mwperina as a code owner June 6, 2022 10:56
@dangel101 dangel101 requested a review from almusil June 6, 2022 10:57
@mwperina mwperina requested a review from erav June 6, 2022 11:46
@almusil
Copy link
Member

almusil commented Jun 6, 2022

Why can't we use the rpm ansible module? Also what happens if the package is missing, as it will be definitely missing on installations >4.4?

@dangel101
Copy link
Member Author

Why can't we use the rpm ansible module? Also what happens if the package is missing, as it will be definitely missing on installations >4.4?

when using yum module dependencies are removed as well (such as vdsm), which are needed. I didn't see a parameter which allows to erase the package and not its dependencies, so I used shell instead
regarding missing package, I added ignore_errors (for using ovirt_openvswitch_pre.version as you suggested we'll need to populate facts again)

@almusil
Copy link
Member

almusil commented Jun 7, 2022

Why can't we use the rpm ansible module? Also what happens if the package is missing, as it will be definitely missing on installations >4.4?

when using yum module dependencies are removed as well (such as vdsm), which are needed. I didn't see a parameter which allows to erase the package and not its dependencies, so I used shell instead regarding missing package, I added ignore_errors (for using ovirt_openvswitch_pre.version as you suggested we'll need to populate facts again)

Well, nothing should depend on this package, that's why we are removing it. Aren't the facts populated before this step? I can see it being called before ovirt-host-upgrade so it should be enough to have this variable populated, anyway it is probably not needed with the ignore_errors.

Copy link
Member

@almusil almusil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a discussion let's leave it this way. Thanks

@@ -36,6 +36,10 @@
- name: Remove network-scripts-openvswitch 2.11 package
shell: rpm -e --nodeps network-scripts-openvswitch2.11
ignore_errors: true
when:
- el_ver|int >= 8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd put there only EL8, because EL7 we don't upgrade and EL9 will already have 2.15

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@mwperina mwperina merged commit 1c21c50 into oVirt:master Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants