core: vnic hot un\plug - avoid race #419
Conversation
|
The change looks good, do we have some reproducer to test it with? I guess oVirt/ovirt-system-tests#175 right? |
Yes, that is the intention of that PR, but the test is not stable and proofable yet |
|
/ost network-suite-master |
|
/ost |
erav
force-pushed
the
vnic-lock-on-hotplug
branch
from
6534e27
to
76d111d
Compare
|
/ost |
1 similar comment
|
/ost |
erav
force-pushed
the
vnic-lock-on-hotplug
branch
from
76d111d
to
7796492
Compare
|
/ost |
1 similar comment
|
/ost |
|
/ost network-suite-master |
1 similar comment
|
/ost network-suite-master |
passed in https://redir.apps.ovirt.org/dj/job/ds-ost-baremetal_manual/40310 |
|
/ost |
passed in https://redir.apps.ovirt.org/dj/job/ds-ost-baremetal_manual/40322 |
erav
force-pushed
the
vnic-lock-on-hotplug
branch
3 times, most recently
from
852f32a
to
f447e8b
Compare
erav
force-pushed
the
vnic-lock-on-hotplug
branch
2 times, most recently
from
8d15a2c
to
68a2763
Compare
erav
force-pushed
the
vnic-lock-on-hotplug
branch
2 times, most recently
from
62bcfae
to
0e377e2
Compare
|
/ost network-suite-master |
Lack of a lock in ActivateDeactivateVmNicCommand allows several instances of hot plug and unplug requests to run in parallel causing inconsistency in vNIC status as well as libvirt failing the requests due to non-unique aliases. This patch adds a lock to the command so that each instance of the command has to finish before the next one starts. Bug-Url: https://bugzilla.redhat.com/2084530 Change-Id: I93ac9f1f12f34526ad10b9a49790c3a2689e8c4d Signed-off-by: Eitan Raviv <eraviv@redhat.com>
Now that there is a lock on the command preventing VmDevicesMonitoring from running while the command is working, there should be no race between the command and VmDevicesMonitoring. Change-Id: I7837dc642c7c55634bc6a7ad69a79049cc291726 Signed-off-by: Eitan Raviv <eraviv@redhat.com>
erav
force-pushed
the
vnic-lock-on-hotplug
branch
from
0e377e2
to
2834041
Compare
|
/ost |
|
/ost network-suite-master |
2 similar comments
|
/ost network-suite-master |
|
/ost network-suite-master |
Lack of a lock in ActivateDeactivateVmNicCommand allows several
instances of hot plug and unplug requests to run in parallel causing an
inconsistent in vNIC status as well as libvirt failing the requests due
to non-unique aliases. This patch adds a lock to the command so that
each instance of the command has to finish before the next one starts.
Bug-Url: https://bugzilla.redhat.com/2084530
Change-Id: I93ac9f1f12f34526ad10b9a49790c3a2689e8c4d
Signed-off-by: Eitan Raviv eraviv@redhat.com