-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: vnic hot un\plug - avoid race #419
Conversation
The change looks good, do we have some reproducer to test it with? I guess oVirt/ovirt-system-tests#175 right? |
Yes, that is the intention of that PR, but the test is not stable and proofable yet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
/ost network-suite-master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, we did the same for hot-(un)plug disks and it works well
/ost |
6534e27
to
76d111d
Compare
/ost |
1 similar comment
/ost |
76d111d
to
7796492
Compare
/ost |
1 similar comment
/ost |
/ost network-suite-master |
1 similar comment
/ost network-suite-master |
passed in https://redir.apps.ovirt.org/dj/job/ds-ost-baremetal_manual/40310 |
/ost |
passed in https://redir.apps.ovirt.org/dj/job/ds-ost-baremetal_manual/40322 |
852f32a
to
f447e8b
Compare
8d15a2c
to
68a2763
Compare
62bcfae
to
0e377e2
Compare
/ost network-suite-master |
Lack of a lock in ActivateDeactivateVmNicCommand allows several instances of hot plug and unplug requests to run in parallel causing inconsistency in vNIC status as well as libvirt failing the requests due to non-unique aliases. This patch adds a lock to the command so that each instance of the command has to finish before the next one starts. Bug-Url: https://bugzilla.redhat.com/2084530 Change-Id: I93ac9f1f12f34526ad10b9a49790c3a2689e8c4d Signed-off-by: Eitan Raviv <eraviv@redhat.com>
Now that there is a lock on the command preventing VmDevicesMonitoring from running while the command is working, there should be no race between the command and VmDevicesMonitoring. Change-Id: I7837dc642c7c55634bc6a7ad69a79049cc291726 Signed-off-by: Eitan Raviv <eraviv@redhat.com>
0e377e2
to
2834041
Compare
/ost |
/ost network-suite-master |
2 similar comments
/ost network-suite-master |
/ost network-suite-master |
Lack of a lock in ActivateDeactivateVmNicCommand allows several
instances of hot plug and unplug requests to run in parallel causing an
inconsistent in vNIC status as well as libvirt failing the requests due
to non-unique aliases. This patch adds a lock to the command so that
each instance of the command has to finish before the next one starts.
Bug-Url: https://bugzilla.redhat.com/2084530
Change-Id: I93ac9f1f12f34526ad10b9a49790c3a2689e8c4d
Signed-off-by: Eitan Raviv eraviv@redhat.com