Encapsulate logic that sets qcow for incremental backup #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahadas
requested review from
sgratch,
ljelinkova,
bennyz,
emesika,
mwperina,
michalskrivanek,
oliel and
didib
as code owners
|
@sgratch there's a comment in AsyncDataProvider that suggests there's a place in ovirt-web-ui that needs to be changed (regardless of this PR - it's just a cleanup, the change itself got in already). can you please take a look? |
sleviim
approved these changes
Jun 23, 2022
|
/ost |
Signed-off-by: Arik Hadas <ahadas@redhat.com>
|
/ost |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor cleanup