Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webadmin: Mark 'Incremental Backup' flag by default #478

Merged
merged 1 commit into from
Jun 21, 2022
Merged

webadmin: Mark 'Incremental Backup' flag by default #478

merged 1 commit into from
Jun 21, 2022

Conversation

sleviim
Copy link
Member

@sleviim sleviim commented Jun 21, 2022

Screenshot: https://imgur.com/a/blTWJqy

When creating a new disk on the UI, the incremental backup flag should
be checked by default.

Bug-Url: https://bugzilla.redhat.com/1915029
Signed-off-by: Shani Leviim sleviim@redhat.com

ljelinkova
ljelinkova reviewed Jun 21, 2022
View reviewed changes
Copy link
Contributor

@ljelinkova ljelinkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that changing the following in the AbstractDiskModel constructor

getIsIncrementalBackup().setEntity(false);

to

getIsIncrementalBackup().setEntity(true);

might do the same thing without adding an additional code.

@sleviim
Copy link
Member Author

sleviim commented Jun 21, 2022

I think that changing the following in the AbstractDiskModel constructor
might do the same thing without adding an additional code.

Thanks, checking

@sleviim
webadmin: Mark 'Incremental Backup' flag by default
ead3a39 
Screenshot: https://imgur.com/a/blTWJqy

When creating a new disk on the UI, the incremental backup flag should
be checked by default.

Bug-Url: https://bugzilla.redhat.com/1915029
Signed-off-by: Shani Leviim <sleviim@redhat.com>
@sleviim sleviim requested a review from ljelinkova June 21, 2022 14:08
@ahadas ahadas merged commit 9510700 into oVirt:master Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahadas ahadas ahadas approved these changes

@sgratch sgratch Awaiting requested review from sgratch sgratch is a code owner

@barpavel barpavel Awaiting requested review from barpavel

@bennyz bennyz Awaiting requested review from bennyz

@mkemel mkemel Awaiting requested review from mkemel

@nirs nirs Awaiting requested review from nirs

@ljelinkova ljelinkova Awaiting requested review from ljelinkova

Assignees
No one assigned
Labels
storage verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sleviim @ljelinkova @ahadas