Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup: Don’t fail cleanup on empty remote engine environment #492

Merged
merged 1 commit into from
Jul 18, 2022
Merged

setup: Don’t fail cleanup on empty remote engine environment #492

merged 1 commit into from
Jul 18, 2022

Commits on Jun 29, 2022

  1. setup: Don’t fail cleanup on empty remote engine environment 

    When engine-setup fails on dnf repositories download, the followup
cleanup fails with

[ ERROR ] Failed to execute stage 'Clean up': 'NoneType' object has no attribute 'cleanup'

This patch moves the corresponding cleanup call from STAGE_CLEANUP to
STAGE_CLOSEUP.  STAGE_CLOSEUP only runs if we didn't fail and runs
non-critical stuff that we can't, or don't want to, rollback.  This
way, we can be sure that the cleanup is not run before the given
environment item is assigned.
    @mz-pdm
    mz-pdm committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    9d3a129 View commit details
    Browse the repository at this point in the history