Filter SDs based on the user permission for snapshot memory disk #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liranr23
requested review from
bennyz,
ahadas,
emesika,
mwperina,
michalskrivanek,
oliel,
sgratch and
didib
as code owners
|
We also use this method (without checking the user) in hibernation and ImportVm. I think it may be good for them to be filtered based on the user as well. WDYT? |
smelamud
approved these changes
Jun 26, 2022
Would be good, IMHO. |
liranr23
force-pushed
the
snap_mem_permission
branch
2 times, most recently
from
204e0c1
to
a66dd28
Compare
|
/ost |
ahadas
reviewed
Jun 27, 2022
...manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryStorageHandler.java
Outdated
Show resolved
Hide resolved
When creating memory disk for live VM snapshot, the engine selects the storage domain to use. The engine might select a storage domain that the current user doesn't have permission on. This will fail to add the memory disk and the snapshot operation will fail. With this patch, the storage domains will be also filtered based on the user permission. Change-Id: Id1a1c529dde795628f214c0c9d9a28efac89eec0 Bug-Url: https://bugzilla.redhat.com/1565183 Signed-off-by: Liran Rotenberg <lrotenbe@redhat.com>
liranr23
force-pushed
the
snap_mem_permission
branch
from
a66dd28
to
3592650
Compare
ahadas
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating memory disk for live VM snapshot, the engine selects the
storage domain to use. The engine might select a storage domain that the
current user doesn't have permission on. This will fail to add the
memory disk and the snapshot operation will fail.
With this patch, the storage domains will be also filtered based on the
user permission.
Change-Id: Id1a1c529dde795628f214c0c9d9a28efac89eec0
Bug-Url: https://bugzilla.redhat.com/1565183
Signed-off-by: Liran Rotenberg lrotenbe@redhat.com