webadmin: fix alignment on Resource Allocation popup #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahadas
reviewed
Jun 27, 2022
...onweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java
Outdated
Show resolved
Hide resolved
...on/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/DisksAllocationView.java
Outdated
Show resolved
Hide resolved
sleviim
force-pushed
the
bug-2081546
branch
2 times, most recently
from
dd06280
to
7edaa2e
Compare
ahadas
approved these changes
Jun 30, 2022
Screenshot: https://imgur.com/a/CAIAnI1 This patch fixes the alignment under Resource Allocation > Disk Allocation, when cloning a VM. The disks' panel is being first created as part of the view initiation. Determining the DC quota level (disabled/enforced) effects the number of columns appear in the disk allocation view. Since updating the quota happens later (not as part of initialization), The columns' width can't be changed unless re-creating the disks lists in the view, so the view needs to be created with the updated width. Bug-Url: https://bugzilla.redhat.com/2081546 Signed-off-by: Shani Leviim <sleviim@redhat.com>
|
/ost |
1 similar comment
|
/ost |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshot: https://imgur.com/a/w1dMuCU
This patch fixes the alignment under Resource Allocation > Disk
Allocation, when cloning a VM.
The disk panel is being first created as part of the view initiation.
Determining the DC quota level (disabled/enforced) affects the number of
columns appear in the disk allocation view.
Since updating the quota happens later (not as part of initialization),
The columns' width can't be changed unless re-creating the disks lists
in the view, so the view needs to be created with the updated width.
Bug-Url: https://bugzilla.redhat.com/2081546
Signed-off-by: Shani Leviim sleviim@redhat.com