engine: Save updated Numa Nodes into NEXT_RUN snapshot #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liranr23
approved these changes
Jun 27, 2022
ahadas
reviewed
Jun 27, 2022
.../manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java
Outdated
Show resolved
Hide resolved
When creating a VM configuration string from the VM object, the NUMA Node list was always updated from the database. This caused that the new settings for the VM were not saved into the NEXT_RUN snapshot. Bug-Url: https://bugzilla.redhat.com/2099225
ljelinkova
force-pushed
the
numa-next-run
branch
from
daec24d
to
6a2a279
Compare
ahadas
approved these changes
Jun 28, 2022
|
/ost |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a VM configuration string from the VM object, the NUMA Node list was always updated from the database. This caused that the new settings for the VM were not saved into the NEXT_RUN snapshot.
Bug-Url: https://bugzilla.redhat.com/2099225