Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't follow gluster-volumes for virt-only cluster #503

Merged
merged 3 commits into from
Jul 14, 2022

Conversation

oliel
Copy link
Contributor

@oliel oliel commented Jun 28, 2022

for clusters that do not have gluster-service (meaning - virt-only), if
the user requests to follow the gluster_volumes link, silently ignore
this request. It doesn't make sense to the Engine and if it reaches it, an
exception will be thrown.

Change-Id: Id2a3c520dae398618d234b0a9c9e29ecab86eac0
Bug-Url: https://bugzilla.redhat.com/2079361
Signed-off-by: Ori Liel oliel@redhat.com

Ori Liel added 3 commits June 28, 2022 15:15
for clusters that do not have gluster-service (meaning - virt-only), if
the user requests to follow the gluster_volumes link, silently ignore
this request. It doesn't make sense to the Engine and if it reaches it, an
exception will be thrown.

Change-Id: Id2a3c520dae398618d234b0a9c9e29ecab86eac0
Bug-Url: https://bugzilla.redhat.com/2079361
Signed-off-by: Ori Liel <oliel@redhat.com>
for clusters that do not have gluster-service (meaning - virt-only), if
the user requests to follow the gluster_volumes link, silently ignore
this request. It doesn't make sense to the Engine and if it reaches it, an
exception will be thrown.

Change-Id: Id2a3c520dae398618d234b0a9c9e29ecab86eac0
Bug-Url: https://bugzilla.redhat.com/2079361
Signed-off-by: Ori Liel <oliel@redhat.com>
Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@mwperina mwperina requested a review from mnecas July 4, 2022 07:28
@sandrobonazzola sandrobonazzola added this to the ovirt-4.5.2 milestone Jul 6, 2022
@oliel
Copy link
Contributor Author

oliel commented Jul 12, 2022

/ost

@oliel oliel marked this pull request as ready for review July 12, 2022 11:30
@oliel
Copy link
Contributor Author

oliel commented Jul 14, 2022

/ost

@oliel oliel merged commit 1691f23 into master Jul 14, 2022
@oliel oliel deleted the Dont_Follow_Cluster_Gluster_Volumes branch July 14, 2022 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants