core: Uploading an image with an existing disk id #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtiomDivak
requested review from
sgratch,
ljelinkova,
bennyz,
ahadas,
emesika,
mwperina,
michalskrivanek,
oliel and
didib
as code owners
|
@ArtiomDivak I didn't look at the code changes but I've noticed that the commit here also doesn't point to the bug, please take a look at how it was done here |
dupondje
reviewed
Jul 4, 2022
...badmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Outdated
Show resolved
Hide resolved
ahadas
reviewed
Jul 5, 2022
...badmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Outdated
Show resolved
Hide resolved
...bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/TransferDiskImageCommand.java
Outdated
Show resolved
Hide resolved
ArtiomDivak
force-pushed
the
bug-2095215
branch
2 times, most recently
from
e21a85b
to
83f4e4d
Compare
ahadas
reviewed
Jul 5, 2022
...badmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Outdated
Show resolved
Hide resolved
ArtiomDivak
force-pushed
the
bug-2095215
branch
2 times, most recently
from
8302bd2
to
0dd453b
Compare
ahadas
reviewed
Jul 6, 2022
...badmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Outdated
Show resolved
Hide resolved
ArtiomDivak
force-pushed
the
bug-2095215
branch
2 times, most recently
from
b988608
to
5aece15
Compare
ahadas
approved these changes
Jul 11, 2022
ljelinkova
reviewed
Jul 12, 2022
...badmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Outdated
Show resolved
Hide resolved
ArtiomDivak
force-pushed
the
bug-2095215
branch
3 times, most recently
from
6945a00
to
c1f613c
Compare
ahadas
approved these changes
Jul 14, 2022
bennyz
approved these changes
Jul 14, 2022
ljelinkova
suggested changes
Jul 14, 2022
indeed |
While uploading users can choose disk-id for thier uplaod and if the disk-id was already existing the engine will make a new image in lock state and fail the prosces. now it will check the disk-id before creating and will fail if there is another disk-id with the same number. Bug-Url: https://bugzilla.redhat.com/2095215 Signed-off-by: Artiom Divak <adivak@redhat.com>
ahadas
approved these changes
Jul 17, 2022
|
/ost |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While uploading users can choose disk-id for their upload and if
the disk-id was already exists the engine will make a new image
in lock state and fail the process. now it will check the disk-id before
creating and will fail if there is another disk-id with the same number.
Bug-Url: https://bugzilla.redhat.com/2095215
Signed-off-by: Artiom Divak adivak@redhat.com