-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: Uploading an image with an existing disk id #507
Conversation
@ArtiomDivak I didn't look at the code changes but I've noticed that the commit here also doesn't point to the bug, please take a look at how it was done here |
...badmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Outdated
Show resolved
Hide resolved
...badmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Outdated
Show resolved
Hide resolved
...bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/TransferDiskImageCommand.java
Outdated
Show resolved
Hide resolved
e21a85b
to
83f4e4d
Compare
...badmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Outdated
Show resolved
Hide resolved
8302bd2
to
0dd453b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor suggestion, besides that looks good
...badmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Outdated
Show resolved
Hide resolved
b988608
to
5aece15
Compare
...badmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Outdated
Show resolved
Hide resolved
6945a00
to
c1f613c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you forgot to add ACTION_TYPE_FAILED_DISK_ALREADY_EXISTS
to AppErrors.java
indeed |
While uploading users can choose disk-id for thier uplaod and if the disk-id was already existing the engine will make a new image in lock state and fail the prosces. now it will check the disk-id before creating and will fail if there is another disk-id with the same number. Bug-Url: https://bugzilla.redhat.com/2095215 Signed-off-by: Artiom Divak <adivak@redhat.com>
/ost |
While uploading users can choose disk-id for their upload and if
the disk-id was already exists the engine will make a new image
in lock state and fail the process. now it will check the disk-id before
creating and will fail if there is another disk-id with the same number.
Bug-Url: https://bugzilla.redhat.com/2095215
Signed-off-by: Artiom Divak adivak@redhat.com