Delete next-run snapshot in a compensation context #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dupondje
requested review from
ahadas,
bennyz,
emesika,
mwperina,
michalskrivanek,
oliel,
sgratch and
didib
as code owners
ahadas
reviewed
Jun 30, 2022
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
Outdated
Show resolved
Hide resolved
The next-run snapshot is created in a compensation context, which causes it to be removed if something fails. But the previous (if exists) next-run snapshot is removed outside the compensation context. This causes the VM's to lose its next-run snapshot if for example an UpdateCluster fails. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=2094729 Signed-off-by: Jean-Louis Dupond jean-louis@dupond.be
dupondje
force-pushed
the
fix_ccv_on_cluster_upgrade
branch
from
d9c6d8c
to
004a397
Compare
dupondje
changed the title
ahadas
approved these changes
Jul 5, 2022
smelamud
approved these changes
Jul 5, 2022
@dupondje, can you please describe the scenario in the bug, so QE will khow how to test it? |
Done! |
Thank you very much for you contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next-run snapshot is created in a compensation context, which causes
it to be removed if something fails.
But the previous (if exists) next-run snapshot is removed outside the
compensation context.
This causes the VM's to lose its next-run snapshot if for example an
UpdateCluster fails.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=2094729
Signed-off-by: Jean-Louis Dupond jean-louis@dupond.be