Release core reminders for isolate threads #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liranr23
requested review from
ahadas,
bennyz,
emesika,
mwperina,
michalskrivanek,
oliel,
sgratch and
didib
as code owners
|
lgtm |
liranr23
force-pushed
the
release_isolated
branch
from
33d5b49
to
14959f6
Compare
|
In the case of |
it does sounds to me we need to consider only the |
liranr23
force-pushed
the
release_isolated
branch
from
14959f6
to
b9cfa17
Compare
|
/ost |
smelamud
approved these changes
Jul 5, 2022
liranr23
force-pushed
the
release_isolated
branch
from
b9cfa17
to
f2e88cb
Compare
ahadas
reviewed
Jul 5, 2022
...ll/src/test/java/org/ovirt/engine/core/bll/scheduling/utils/VdsCpuUnitPinningHelperTest.java
Outdated
Show resolved
Hide resolved
...ll/src/test/java/org/ovirt/engine/core/bll/scheduling/utils/VdsCpuUnitPinningHelperTest.java
Outdated
Show resolved
Hide resolved
liranr23
force-pushed
the
release_isolated
branch
from
f2e88cb
to
375cb69
Compare
smelamud
approved these changes
Jul 7, 2022
mz-pdm
reviewed
Jul 11, 2022
...es/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/utils/VdsCpuUnitPinningHelper.java
Outdated
Show resolved
Hide resolved
We now release using unPin the VdsCpuUnit we need. This is good for `dedicated` policy. When we are handling `isolate-threads` policy we need to release the whole core. Otherwise the engine thinks it's taken. Change-Id: I0b028e0dc5db72f5ef3099059f355d975a81fc90 Bug-Url: https://bugzilla.redhat.com/2103620 Signed-off-by: Liran Rotenberg <lrotenbe@redhat.com>
liranr23
force-pushed
the
release_isolated
branch
from
375cb69
to
56c2646
Compare
ljelinkova
approved these changes
Jul 12, 2022
smelamud
approved these changes
Jul 12, 2022
|
Good, looks nicer now! |
|
/ost |
ahadas
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now release using unPin the VdsCpuUnit we need. This is good for
dedicatedpolicy. When we are handlingisolate-threadspolicy weneed to release the whole core. Otherwise the engine thinks it's taken.
Change-Id: I0b028e0dc5db72f5ef3099059f355d975a81fc90
Bug-Url: https://bugzilla.redhat.com/2103620
Signed-off-by: Liran Rotenberg lrotenbe@redhat.com