-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release core reminders for isolate threads #511
Conversation
lgtm |
33d5b49
to
14959f6
Compare
In the case of |
it does sounds to me we need to consider only the |
14959f6
to
b9cfa17
Compare
/ost |
b9cfa17
to
f2e88cb
Compare
...ll/src/test/java/org/ovirt/engine/core/bll/scheduling/utils/VdsCpuUnitPinningHelperTest.java
Outdated
Show resolved
Hide resolved
...ll/src/test/java/org/ovirt/engine/core/bll/scheduling/utils/VdsCpuUnitPinningHelperTest.java
Outdated
Show resolved
Hide resolved
f2e88cb
to
375cb69
Compare
...es/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/utils/VdsCpuUnitPinningHelper.java
Outdated
Show resolved
Hide resolved
We now release using unPin the VdsCpuUnit we need. This is good for `dedicated` policy. When we are handling `isolate-threads` policy we need to release the whole core. Otherwise the engine thinks it's taken. Change-Id: I0b028e0dc5db72f5ef3099059f355d975a81fc90 Bug-Url: https://bugzilla.redhat.com/2103620 Signed-off-by: Liran Rotenberg <lrotenbe@redhat.com>
375cb69
to
56c2646
Compare
Good, looks nicer now! |
/ost |
We now release using unPin the VdsCpuUnit we need. This is good for
dedicated
policy. When we are handlingisolate-threads
policy weneed to release the whole core. Otherwise the engine thinks it's taken.
Change-Id: I0b028e0dc5db72f5ef3099059f355d975a81fc90
Bug-Url: https://bugzilla.redhat.com/2103620
Signed-off-by: Liran Rotenberg lrotenbe@redhat.com