core: measure unattached disks #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ost |
bennyz
force-pushed
the
fix-measure-condition
branch
from
b15badf
to
f327d34
Compare
|
/ost |
ahadas
reviewed
Jul 31, 2022
...ava/org/ovirt/engine/core/bll/storage/disk/image/CloneImageGroupVolumesStructureCommand.java
Outdated
Show resolved
Hide resolved
The current check doesn't doesn't use measureVolume if the volume is a leaf, but there is no reason to do this if the disk is not attached to a running a VM. This patch checks if the disk is attached to a running VM before checking if the volume is a leaf to ensure it's measured correctly. Bug-Url: https://bugzilla.redhat.com/2104806 Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
bennyz
force-pushed
the
fix-measure-condition
branch
from
f327d34
to
7b4d1bd
Compare
|
/ost |
ahadas
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current check doesn't use measureVolume if the volume is a leaf, but there is no reason to do this if the disk is not attached to a running a VM.
This patch checks if the disk is attached to a running VM before checking if the volume is a leaf to ensure it's measured correctly.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=2104806