core: Return validation messages from SchedulingManager #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smelamud
requested review from
ahadas,
bennyz,
emesika,
mwperina,
michalskrivanek,
oliel,
sgratch and
didib
as code owners
liranr23
approved these changes
Jul 7, 2022
ahadas
reviewed
Jul 11, 2022
...d/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateMultipleVmsCommand.java
Outdated
Show resolved
Hide resolved
If validation of MigrateMultipleVmsCommand fails because SchedulingManager.canSchedule() returns an empty list of hosts, need to pass error messages from SchedulingManager up by command invocation hierarchy, so they could be displayed to the user. Change-Id: I4db998b4840129e6be03fbe99417286de16f223b Bug-Url: https://bugzilla.redhat.com/1789389 Signed-off-by: Shmuel Melamud <smelamud@redhat.com>
ahadas
approved these changes
Jul 13, 2022
|
/ost |
1 similar comment
|
/ost |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If validation of MigrateMultipleVmsCommand fails because
SchedulingManager.canSchedule() returns an empty list of hosts, need to
pass error messages from SchedulingManager up by command invocation
hierarchy, so they could be displayed to the user.
Change-Id: I4db998b4840129e6be03fbe99417286de16f223b
Bug-Url: https://bugzilla.redhat.com/1789389
Signed-off-by: Shmuel Melamud smelamud@redhat.com