core: set correct policy when reseting cpu pinning string #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we are importing a VM that is pinned to a host, and the host is not present in the cluster where the VM should be imported, the host pinning is cleared as well as the cpu pinning string. However, the cpu pinning policy was not updated and remained MANUAL causing the import to fail when inserting the VM into the database. This patch updates the cpu pinning policy to NONE when cpu pinning string is cleared during import. Bug-Url: https://bugzilla.redhat.com/2104115
ljelinkova
requested review from
bennyz,
emesika,
mwperina,
michalskrivanek,
oliel,
sgratch and
didib
as code owners
smelamud
approved these changes
Jul 12, 2022
mz-pdm
approved these changes
Jul 12, 2022
|
/ost |
1 similar comment
|
/ost |
|
/ost |
ahadas
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we are importing a VM that is pinned to a host, and the host is not present in the cluster where the VM should be imported, the host pinning is cleared as well as the cpu pinning string. However, the cpu pinning policy was not updated and remained MANUAL causing the import to fail when inserting the VM into the database.
This patch updates the cpu pinning policy to NONE when cpu pinning string is cleared during import.
Bug-Url: https://bugzilla.redhat.com/2104115