core: do not use double-brace initialization for parameter value #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennyz
changed the title
Initializing a HashMap with double-brace create an inner class and the
value of diskImagesMap will be a HashMap wrapped in:
org.ovirt.engine.core.bll.storage.lsm.LiveMigrateDiskCommand$1
Instead of just a HashMap, and LiveMigrateDiskCommand is not deserializable
which will prevent ovirt-engine from starting when it tries to reload
command_entities
Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
bennyz
force-pushed
the
fix-disk-images-map
branch
from
ebdfd4f
to
8167f08
Compare
|
/ost |
ahadas
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initializing a HashMap with double-brace create an inner class and the
value of diskImagesMap will be a HashMap wrapped in:
Instead of just a HashMap, and LiveMigrateDiskCommand is not deserializable which will prevent ovirt-engine from starting when it tries to reload command_entities