-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: Ignore isValid() == false, if migration succeeded #535
Conversation
In MaintenanceVdsCommand, if migrateAllVms() returned successful return value, do not check isValid() and do not copy validation messages from it. Change-Id: I9c38423c88b7a4e8a84d6187835abe490278def5 Bug-Url: https://bugzilla.redhat.com/2108000 Signed-off-by: Shmuel Melamud <smelamud@redhat.com>
/ost |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change is alright - indeed we need to take the validation result(s) only in case the command didn't succeed. I wonder though how come that we end up in this state in which we get isValid==false and succeeded=true - maybe we have an issue in MigrateVmToServer..
ah no, I think I get it now - it's probably not MigrateVmToServer that fools us but MigrateMultipleVmsCommand which adds the validation messages for vms that the scheduler failed on (in the validation phase), yet proceeds with those that it managed to schedule, if exist (and in the execute phase it surprisingly fails if it is not able to migrate all the vms..) - @smelamud does it match the scenario you saw? |
@smelamud I'm getting this in so we'll get feedback from our automation on this but please reply to the question above |
ack, so that happens only when moving a host with no running vm to maintenance then. I don't think we need #536, this change would be enough |
In MaintenanceVdsCommand, if migrateAllVms() returned successful return
value, do not check isValid() and do not copy validation messages from
it.
Change-Id: I9c38423c88b7a4e8a84d6187835abe490278def5
Bug-Url: https://bugzilla.redhat.com/2108000
Signed-off-by: Shmuel Melamud smelamud@redhat.com