core: Check if VM exists with ID of the imported template #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smelamud
requested review from
sgratch,
ljelinkova,
ahadas,
bennyz,
emesika,
mwperina,
michalskrivanek,
oliel and
didib
as code owners
ahadas
reviewed
Jul 20, 2022
...es/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommandBase.java
Outdated
Show resolved
Hide resolved
When importing a template, both templates and VMs should be checked to ensure that the same ID does not exist in the system. To achieve this, vm_static table is used. Change-Id: Ia416f058995ce580708eddcc3fea2040c0b170ea Bug-Url: https://bugzilla.redhat.com/1853924 Signed-off-by: Shmuel Melamud <smelamud@redhat.com>
smelamud
force-pushed
the
bug-1853924-validate
branch
from
5e15996
to
9279af9
Compare
liranr23
approved these changes
Jul 21, 2022
ljelinkova
approved these changes
Jul 21, 2022
michalskrivanek
pushed a commit
to michalskrivanek/ovirt-engine
that referenced
this pull request
Jul 26, 2022
When importing a template, both templates and VMs should be checked to ensure that the same ID does not exist in the system. To achieve this, vm_static table is used. Change-Id: Ia416f058995ce580708eddcc3fea2040c0b170ea Bug-Url: https://bugzilla.redhat.com/1853924 Signed-off-by: Shmuel Melamud <smelamud@redhat.com>
michalskrivanek
pushed a commit
to michalskrivanek/ovirt-engine
that referenced
this pull request
Jul 26, 2022
When importing a template, both templates and VMs should be checked to ensure that the same ID does not exist in the system. To achieve this, vm_static table is used. Change-Id: Ia416f058995ce580708eddcc3fea2040c0b170ea Bug-Url: https://bugzilla.redhat.com/1853924 Signed-off-by: Shmuel Melamud <smelamud@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When importing a template, both templates and VMs should be checked to
ensure that the same ID does not exist in the system. To achieve this,
vm_static table is used.
Change-Id: Ia416f058995ce580708eddcc3fea2040c0b170ea
Bug-Url: https://bugzilla.redhat.com/1853924
Signed-off-by: Shmuel Melamud smelamud@redhat.com