core: pass DiskBackup to CreateVolumeContainer #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahadas
approved these changes
Jul 20, 2022
|
@bennyz wouldn't it solve bz 2108182 as well? |
I don't think it affects the disk size, but I'll try and make sure |
ah right, I see the comments inside - wasn't there another bug about the allocation policy that we said it might be a result of the backup property? maybe there wasn't another one Edit: never mind, I think it was a conversation I had with myself when looking at the bug above before writing comment 1.. |
|
/ost |
Not passing DiskBackup from ConvertDiskCommand will result in the allocation policy being overriden and consequnetly fail the conversion. This patch sets DiskBackup and always passes it to ConvertDiskCommand. Bug-Url: https://bugzilla.redhat.com/2108012 Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
bennyz
force-pushed
the
fix-backup-convert
branch
from
09891bb
to
9dcece5
Compare
|
/ost |
|
OST failure unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not passing DiskBackup from ConvertDiskCommand will result in the allocation policy being overridden and consequently fail the conversion.
This patch sets DiskBackup and always passes it to ConvertDiskCommand.
Bug-Url: https://bugzilla.redhat.com/2108012