core: Fix NPE on invalid affinity group ID #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added null check in AffinityGroupCRUDCommand.getClusterId() to avoid NPE when the affinity group does not exist. The command fails in the validation later. Change-Id: I473969a190ab5db1577615d28970d72e10341846 Bug-Url: https://bugzilla.redhat.com/2067104 Signed-off-by: Shmuel Melamud <smelamud@redhat.com>
smelamud
requested review from
ahadas,
bennyz,
emesika,
mwperina,
michalskrivanek,
oliel,
sgratch,
didib and
ljelinkova
as code owners
ahadas
approved these changes
Jul 25, 2022
|
/ost |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added null check in AffinityGroupCRUDCommand.getClusterId() to avoid NPE
when the affinity group does not exist. The command fails in the
validation later.
Change-Id: I473969a190ab5db1577615d28970d72e10341846
Bug-Url: https://bugzilla.redhat.com/2067104
Signed-off-by: Shmuel Melamud smelamud@redhat.com