-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core,restapi: report iscsi server address and port for direct LUNs #559
Conversation
bennyz
commented
Jul 26, 2022
•
edited
Loading
edited
...restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageLogicalUnitMapper.java
Outdated
Show resolved
Hide resolved
b498a0d
to
c764f21
Compare
/ost |
This handles only |
yes, I'm aware, need to see if it's enough for our purposes first |
@@ -48,6 +48,11 @@ public static LogicalUnit map(LUNs entity, LogicalUnit template) { | |||
model.setSize(SizeConverter.convert((long)entity.getDeviceSize(), | |||
SizeConverter.SizeUnit.GiB, SizeConverter.SizeUnit.BYTES).longValue()); | |||
|
|||
if (entity.getLunConnections() != null && !entity.getLunConnections().isEmpty()) { | |||
model.setAddress(entity.getLunConnections().get(0).getConnection()); | |||
model.setPort(Integer.valueOf(entity.getLunConnections().get(0).getPort())); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not having the whole details of StorageServerConnections
? we will need the iqn(target) for example
c764f21
to
6251e3f
Compare
...l/src/main/java/org/ovirt/engine/core/bll/storage/disk/GetDiskAndSnapshotsByDiskIdQuery.java
Outdated
Show resolved
Hide resolved
...restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageLogicalUnitMapper.java
Outdated
Show resolved
Hide resolved
06823c4
to
efeae5b
Compare
efeae5b
to
7643dab
Compare
/ost |
...restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageLogicalUnitMapper.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
99eca5b
to
b5cb2ab
Compare
b5cb2ab
to
0eb435c
Compare
/ost |