update variables to make host upgrade work with rhel7 #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ost |
mwperina
requested changes
Aug 2, 2022
| ovirt_openvswitch_pre: "{{ ansible_facts.packages['openvswitch'] | first }}" | ||
| when: | ||
| - ansible_facts.packages['openvswitch'] is defined | ||
|
|
There was a problem hiding this comment.
This is not good, OVS/OVN upgrade from 2.11 to 2.15 should happen only on EL8. On EL7 we should stay on OVS/OVN 2.11 forever (no longer supported since 4.5.0) and on EL9 we have 2.15 from beginning.
So we should check for el_ver | int == 8 in blocks dealing with 2.11 -> 2.15 upgrade
There was a problem hiding this comment.
It could have been >= because there is no chance that the pre version will be 2.11 on el9, but this will work as well.
|
/ost |
almusil
approved these changes
Aug 3, 2022
mwperina
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=2107250