-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perform cleanup after insufficient free space error during LSM #568
Perform cleanup after insufficient free space error during LSM #568
Conversation
/ost |
c5ad592
to
211d4e7
Compare
83dee51
to
0612c36
Compare
Code improvements for methods that handle destination disk cleanups in case of Live Storage Migration failure. 1. Renaming cleanup method to "cleanupDestDiskAfterFailure()". 2. "removeImage()" method calls reformatting for for readability. Signed-off-by: Pavel Bar <pbar@redhat.com> Bug-Url: https://bugzilla.redhat.com/2102149
In case of Live Storage Migration failure during "LiveDiskMigrateStage.CLONE_IMAGE_STRUCTURE" the "removeImage()" cleanup was skipped. It should be performed in order to free the already allocated space on the target Storage Domain. Signed-off-by: Pavel Bar <pbar@redhat.com> Bug-Url: https://bugzilla.redhat.com/2102149
0612c36
to
733e883
Compare
/ost |
Tested it again with my latest (today's) changes and synced with latest master. |
that's a fair point @barpavel :) |
In case of Live Storage Migration failure during
LiveDiskMigrateStage.CLONE_IMAGE_STRUCTURE
the remove image cleanup was skipped.It should be performed in order to free the already allocated space on the target Storage Domain.
Bug-Url: https://bugzilla.redhat.com/2102149