Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump_release.sh: Create a tag for the release #597

Closed
wants to merge 1 commit into from

Conversation

didib
Copy link
Member

@didib didib commented Aug 18, 2022

Change-Id: I005a79fa4df940e6475bae4559bff61e1086c11a
Signed-off-by: Yedidyah Bar David didi@redhat.com

Change-Id: I005a79fa4df940e6475bae4559bff61e1086c11a
Signed-off-by: Yedidyah Bar David <didi@redhat.com>
@didib
Copy link
Member Author

didib commented Aug 18, 2022

Tested locally:

  1. RPM_PACKAGER='Yedidyah Bar David <didi@redhat.com>' ./bump_release.sh, worked well
  2. Dropped last two commits with rebase -i HEAD~3
  3. Ran again, it failed because tag already exists
  4. Removed the tag, ran again, worked well

Copy link
Member

@michalskrivanek michalskrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. If it's not too hard can we add a note / check this runs against origin, not fork?

@didib
Copy link
Member Author

didib commented Aug 18, 2022

Thanks. If it's not too hard can we add a note / check this runs against origin, not fork?

Not sure what you mean. This is all locally. It's up to users to then push wherever they want, or just delete the tag, if it was just for testing, like above.

@didib
Copy link
Member Author

didib commented Aug 22, 2022

included in #599

@didib didib closed this Aug 22, 2022
@didib didib deleted the bump_release-create-a-tag branch August 22, 2022 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants