core: Add support for zero-copy migrations

backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java

@@ -405,19 +405,22 @@ private MigrateVDSCommandParameters createMigrateVDSCommandParameters() {
         Integer maxBandwidth = null;
 
         Boolean autoConverge = getAutoConverge();
-        Integer parallelMigrations = getParallelMigrations();
-        Boolean migrateCompressed = parallelMigrations == null ? getMigrateCompressed() : false;
         Boolean migrateEncrypted = vmHandler.getMigrateEncrypted(getVm(), getCluster());
         Boolean enableGuestEvents = null;
+        MigrationPolicy clusterMigrationPolicy = convergenceConfigProvider.getMigrationPolicy(
+                getCluster().getMigrationPolicyId(),
+                getCluster().getCompatibilityVersion());
+        MigrationPolicy effectiveMigrationPolicy = findEffectiveConvergenceConfig(clusterMigrationPolicy);
+        boolean zeroCopy = effectiveMigrationPolicy.isZeroCopy()
+                && FeatureSupported.isParallelMigrationsSupported(getVm().getCompatibilityVersion())
+                && !migrateEncrypted;
+        Integer parallelMigrations = getParallelMigrations(zeroCopy);
+        Boolean migrateCompressed = parallelMigrations == null ? getMigrateCompressed() : false;
         Integer maxIncomingMigrations = 1;
         Integer maxOutgoingMigrations = 1;
         List<String> cpuSets = null;
         List<String> numaNodeSets = null;
 
-        MigrationPolicy clusterMigrationPolicy = convergenceConfigProvider.getMigrationPolicy(
-                getCluster().getMigrationPolicyId(),
-                getCluster().getCompatibilityVersion());
-        MigrationPolicy effectiveMigrationPolicy = findEffectiveConvergenceConfig(clusterMigrationPolicy);
         ConvergenceConfig convergenceConfig = getVm().getStatus() == VMStatus.Paused || parallelMigrations != null
                 ? filterOutPostcopy(effectiveMigrationPolicy.getConfig())
                 : effectiveMigrationPolicy.getConfig();
@@ -463,6 +466,7 @@ private MigrateVDSCommandParameters createMigrateVDSCommandParameters() {
                 getDestinationVds().getConsoleAddress(),
                 maxBandwidth,
                 parallelMigrations,
+                zeroCopy,
                 convergenceSchedule,
                 enableGuestEvents,
                 maxIncomingMigrations,
@@ -572,18 +576,25 @@ private Integer getLinkSpeedBandwidth(Guid hostId) {
     }
 
     /**
+     * @param enforce If true then use parallel migration even if they would be normally disabled.
      * @return Number of parallel migrations to use in this migration or `null` to
      *         not use parallel migrations.
      */
-    private Integer getParallelMigrations() {
+    private Integer getParallelMigrations(boolean enforce) {
         if (!FeatureSupported.isParallelMigrationsSupported(getVm().getCompatibilityVersion())) {
             return null;
         }
         Integer parallelMigrationsRequested = getParallelMigrationsFromVmOrCluster();
+        if (enforce && (parallelMigrationsRequested == ParallelMigrationsType.DISABLED.getValue()
+                || parallelMigrationsRequested == ParallelMigrationsType.AUTO.getValue())) {
+            parallelMigrationsRequested = ParallelMigrationsType.AUTO_PARALLEL.getValue();
+        }
         Integer parallelMigrations = parallelMigrationsRequested;
-        if (parallelMigrationsRequested < 0) {
+        if (parallelMigrationsRequested == ParallelMigrationsType.AUTO.getValue()
+                || parallelMigrationsRequested == ParallelMigrationsType.AUTO_PARALLEL.getValue()) {
             parallelMigrations = calculateAutomaticParallelMigrations();
-            if (parallelMigrations == null && parallelMigrationsRequested == -1) {
+            if (parallelMigrations == null
+                    && parallelMigrationsRequested == ParallelMigrationsType.AUTO_PARALLEL.getValue()) {
                 parallelMigrations = ParallelMigrationsType.MIN_PARALLEL_CONNECTIONS;
             }
         } else {

backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidator.java

@@ -43,6 +43,7 @@
 import org.ovirt.engine.core.common.config.Config;
 import org.ovirt.engine.core.common.config.ConfigValues;
 import org.ovirt.engine.core.common.errors.EngineMessage;
+import org.ovirt.engine.core.common.migration.ParallelMigrationsType;
 import org.ovirt.engine.core.common.osinfo.OsRepository;
 import org.ovirt.engine.core.common.utils.customprop.VmPropertiesUtils;
 import org.ovirt.engine.core.compat.Guid;
@@ -492,8 +493,10 @@ public ValidationResult isVmStatusIn(VMStatus... statuses) {
     }
 
     public static ValidationResult isParallelMigrationsValid(Integer parallelMigrations) {
-        if (parallelMigrations != null
-                && (parallelMigrations < -2 || parallelMigrations == 1 || parallelMigrations > 255)) {
+        if (parallelMigrations != null && (parallelMigrations <= 1 || parallelMigrations > 255)
+                && parallelMigrations != ParallelMigrationsType.AUTO.getValue()
+                && parallelMigrations != ParallelMigrationsType.AUTO_PARALLEL.getValue()
+                && parallelMigrations != ParallelMigrationsType.DISABLED.getValue()) {
             return new ValidationResult(EngineMessage.VALIDATION_PARALLEL_MIGRATIONS_RANGE);
         }
         return ValidationResult.VALID;

backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Cluster.java

@@ -10,6 +10,7 @@
 import javax.validation.constraints.NotNull;
 import javax.validation.constraints.Size;
 
+import org.ovirt.engine.core.common.migration.ParallelMigrationsType;
 import org.ovirt.engine.core.common.network.FirewallType;
 import org.ovirt.engine.core.common.network.SwitchType;
 import org.ovirt.engine.core.common.scheduling.ClusterPolicy;
@@ -192,7 +193,7 @@ public Cluster() {
         enableKsm = true;
         ksmMergeAcrossNumaNodes = true;
         migrationBandwidthLimitType = MigrationBandwidthLimitType.DEFAULT;
-        parallelMigrations = 0;
+        parallelMigrations = ParallelMigrationsType.DISABLED.getValue();
         requiredSwitchTypeForCluster = SwitchType.LEGACY;
         logMaxMemoryUsedThresholdType = LogMaxMemoryUsedThresholdType.PERCENTAGE;
         description = "";

backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/migration/MigrationPolicy.java

@@ -21,6 +21,8 @@ public class MigrationPolicy implements Serializable, Nameable {
 
     private boolean enableGuestEvents;
 
+    private boolean zeroCopy;
+
     private ConvergenceConfig config;
 
     public MigrationPolicy() {}
@@ -95,4 +97,12 @@ public boolean isEnableGuestEvents() {
     public void setEnableGuestEvents(boolean enableGuestEvents) {
         this.enableGuestEvents = enableGuestEvents;
     }
+
+    public boolean isZeroCopy() {
+        return zeroCopy;
+    }
+
+    public void setZeroCopy(boolean zeroCopy) {
+        this.zeroCopy = zeroCopy;
+    }
 }

backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/MigrateVDSCommandParameters.java

@@ -23,6 +23,7 @@ public class MigrateVDSCommandParameters extends VdsAndVmIDVDSParametersBase {
     private String consoleAddress;
     private Integer maxBandwidth;
     private Integer parallelMigrations;
+    private boolean zeroCopy;
     private Boolean enableGuestEvents;
     private Integer maxIncomingMigrations;
     private Integer maxOutgoingMigrations;
@@ -34,7 +35,7 @@ public class MigrateVDSCommandParameters extends VdsAndVmIDVDSParametersBase {
     public MigrateVDSCommandParameters(Guid vdsId, Guid vmId, String srcHost, Guid dstVdsId, String dstHost,
             MigrationMethod migrationMethod, boolean tunnelMigration, String dstQemu, Version clusterVersion,
             int migrationDowntime, Boolean autoConverge, Boolean migrateCompressed, Boolean migrateEncrypted,
-            String consoleAddress, Integer maxBandwidth, Integer parallelMigrations,
+            String consoleAddress, Integer maxBandwidth, Integer parallelMigrations, boolean zeroCopy,
             Map<String, Object> convergenceSchedule, Boolean enableGuestEvents, Integer maxIncomingMigrations,
             Integer maxOutgoingMigrations, List<String> cpuSets, List<String> numaNodeSets) {
         super(vdsId, vmId);
@@ -52,6 +53,7 @@ public MigrateVDSCommandParameters(Guid vdsId, Guid vmId, String srcHost, Guid d
         this.consoleAddress = consoleAddress;
         this.maxBandwidth = maxBandwidth;
         this.parallelMigrations = parallelMigrations;
+        this.zeroCopy = zeroCopy;
         this.convergenceSchedule = convergenceSchedule;
         this.enableGuestEvents = enableGuestEvents;
         this.maxIncomingMigrations = maxIncomingMigrations;
@@ -156,6 +158,14 @@ public void setParallelMigrations(Integer parallelMigrations) {
         this.parallelMigrations = parallelMigrations;
     }
 
+    public boolean isZeroCopy() {
+        return zeroCopy;
+    }
+
+    public void setZeroCopy(boolean zeroCopy) {
+        this.zeroCopy = zeroCopy;
+    }
+
     public Boolean isEnableGuestEvents() {
         return enableGuestEvents;
     }

backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/MigrationOptionsMapper.java

@@ -5,6 +5,7 @@
 import org.ovirt.engine.api.model.MigrationPolicy;
 import org.ovirt.engine.api.model.ParallelMigrationsPolicy;
 import org.ovirt.engine.core.common.businessentities.HasMigrationOptions;
+import org.ovirt.engine.core.common.migration.ParallelMigrationsType;
 import org.ovirt.engine.core.compat.Guid;
 
 public class MigrationOptionsMapper {
@@ -72,13 +73,13 @@ public static void copyMigrationOptions(MigrationOptions model, HasMigrationOpti
             case INHERIT:
                 break;
             case AUTO:
-                parallelMigrations = -2;
+                parallelMigrations = ParallelMigrationsType.AUTO.getValue();
                 break;
             case AUTO_PARALLEL:
-                parallelMigrations = -1;
+                parallelMigrations = ParallelMigrationsType.AUTO_PARALLEL.getValue();
                 break;
             case DISABLED:
-                parallelMigrations = 0;
+                parallelMigrations = ParallelMigrationsType.DISABLED.getValue();
                 break;
             case CUSTOM:
                 if (customParallelMigrations != null && customParallelMigrations >= 1) {

backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/MigrateBrokerVDSCommand.java

@@ -61,6 +61,10 @@ private Map<String, Object> createMigrationInfo() {
             migrationInfo.put(VdsProperties.PARALLEL_MIGRATION_CONNECTIONS, parameters.getParallelMigrations());
         }
 
+        if (parameters.isZeroCopy()) {
+            migrationInfo.put(VdsProperties.MIGRATION_ZEROCOPY, parameters.isZeroCopy());
+        }
+
         if (parameters.getConvergenceSchedule() != null) {
             migrationInfo.put(VdsProperties.MIGRATION_CONVERGENCE_SCHEDULE, parameters.getConvergenceSchedule());
         }

backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java

@@ -443,6 +443,7 @@ public final class VdsProperties {
     public static final String ENABLE_GUEST_EVENTS = "enableGuestEvents";
     public static final String MIGRATION_BANDWIDTH = "maxBandwidth";
     public static final String PARALLEL_MIGRATION_CONNECTIONS = "parallel";
+    public static final String MIGRATION_ZEROCOPY = "zerocopy";
     public static final String MIGRATION_INIT_STEPS = "init";
     public static final String MIGRATION_STALLING_STEPS = "stalling";
     public static final String MIGRATION_SOURCE = "Migration Source";

frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/MigrationsModelToEntityBuilder.java

@@ -25,15 +25,25 @@ public void build(S source, D destination) {
         buildParallelMigrations(source, destination);
     }
 
+    private Integer sourceToDestinationMigrations(S source, ParallelMigrationsType parallelMigrationsType) {
+        if (parallelMigrationsType == null) {
+            return null;
+        }
+        switch (parallelMigrationsType) {
+        case AUTO:
+            return ParallelMigrationsType.AUTO.getValue();
+        case AUTO_PARALLEL:
+            return ParallelMigrationsType.AUTO_PARALLEL.getValue();
+        case DISABLED:
+            return ParallelMigrationsType.DISABLED.getValue();
+        default:
+            return source.getCustomParallelMigrations().getEntity();
+        }
+    }
+
     private void buildParallelMigrations(S source, D destination) {
         // null value is not applicable for clusters but it should never occur there
         final ParallelMigrationsType parallelMigrationsType = source.getParallelMigrationsType().getSelectedItem();
-        final Integer parallelMigrations =
-            parallelMigrationsType == null ? null :
-            parallelMigrationsType == ParallelMigrationsType.AUTO ? -2 :
-            parallelMigrationsType == ParallelMigrationsType.AUTO_PARALLEL ? -1 :
-            parallelMigrationsType == ParallelMigrationsType.DISABLED ? 0 :
-            source.getCustomParallelMigrations().getEntity();
-        destination.setParallelMigrations(parallelMigrations);
+        destination.setParallelMigrations(sourceToDestinationMigrations(source, parallelMigrationsType));
     }
 }

frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java

@@ -12,6 +12,7 @@
 import java.util.Map;
 import java.util.Objects;
 import java.util.Set;
+import java.util.stream.Collectors;
 
 import org.ovirt.engine.core.common.businessentities.AdditionalFeature;
 import org.ovirt.engine.core.common.businessentities.ArchitectureType;
@@ -1523,6 +1524,9 @@ public void refreshMigrationPolicies() {
         }
 
         List<MigrationPolicy> policies = AsyncDataProvider.getInstance().getMigrationPolicies(version);
+        if (version == null || !AsyncDataProvider.getInstance().isParallelMigrationsSupportedByVersion(version)) {
+            policies = policies.stream().filter(policy -> !policy.isZeroCopy()).collect(Collectors.toList());
+        }
         getMigrationPolicies().setItems(policies);
 
         MigrationPolicy migrationPolicy;

frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java

@@ -3855,6 +3855,9 @@ private void refreshMigrationPolicies() {
         }
 
         List<MigrationPolicy> policies = AsyncDataProvider.getInstance().getMigrationPolicies(version);
+        if (version == null || !AsyncDataProvider.getInstance().isParallelMigrationsSupportedByVersion(version)) {
+            policies = policies.stream().filter(policy -> !policy.isZeroCopy()).collect(Collectors.toList());
+        }
 
         Guid clusterMigrationPolicyID = selectedCluster.getMigrationPolicyId();
         for (MigrationPolicy policy : policies) {

frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedMigrationPolicies.java

@@ -15,5 +15,9 @@ public interface LocalizedMigrationPolicies extends ConstantsWithLookup {
     String name_a7aeedb2_8d66_4e51_bb22_32595027ce71();
 
     String description_a7aeedb2_8d66_4e51_bb22_32595027ce71();
+
+    String name_57237b82_b8c2_425f_b425_114b35219626();
+
+    String description_57237b82_b8c2_425f_b425_114b35219626();
 }
 

frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedMigrationPolicies.properties

@@ -3,4 +3,6 @@ description_80554327_0569_496b_bdeb_fcbbf52b827b=A policy that lets the VM migra
 name_80554327_0569_496b_bdeb_fcbbf52b827c=Suspend workload if needed
 description_80554327_0569_496b_bdeb_fcbbf52b827c=A policy that lets the VM migrate in most situations, including VMs running heavy workloads. On the other hand, the VM may experience a more significant downtime. The migration may still be aborted for extreme workloads. The guest agent hook mechanism is enabled.
 name_a7aeedb2_8d66_4e51_bb22_32595027ce71=Post-copy migration
-description_a7aeedb2_8d66_4e51_bb22_32595027ce71=The VM should not experience any significant downtime. If the VM migration is not converging for a long time, the migration will be switched to post-copy. The guest agent hook mechanism is enabled.
+description_a7aeedb2_8d66_4e51_bb22_32595027ce71=The VM should not experience any significant downtime. If the VM migration is not converging for a long time, the migration will be switched to post-copy. The guest agent hook mechanism is enabled.
+name_57237b82_b8c2_425f_b425_114b35219626=Very large VMs
+description_57237b82_b8c2_425f_b425_114b35219626=The VM cannot be migrated using any of the other policies, a possibly risky migration mechanism is accepted and the migration need not be encrypted. The VM may experience a significant downtime. The migration may still be aborted if it cannot converge. The guest agent hook mechanism is enabled.