ui: Changed Incremental Backup from default true to false #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we want to unset the checkbox only for ISO disks, not regular disks |
ArtiomDivak
force-pushed
the
bug-2120228
branch
from
4aa7ead
to
a905c20
Compare
smelamud
requested changes
Aug 24, 2022
...commonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java
Outdated
Show resolved
Hide resolved
ahadas
reviewed
Aug 25, 2022
...commonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java
Outdated
Show resolved
Hide resolved
ArtiomDivak
force-pushed
the
bug-2120228
branch
from
a905c20
to
8fbacef
Compare
ahadas
approved these changes
Aug 29, 2022
When a user will try to upload ISO file the Incremental Backup will be set to false and uncheckable Bug-Url: https://bugzilla.redhat.com/2120228 Signed-off-by: Artiom Divak <adivak@redhat.com>
|
/ost |
|
ost doesn't check it anyway and fails during the initialization part.. |
not good to ignore testing... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user will try to upload ISO file the Incremental Backup will be
set to false and uncheckable
Bug-Url: https://bugzilla.redhat.com/2120228
Signed-off-by: Artiom Divak adivak@redhat.com