Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require extra 8 GiB free space on the destination Storage Domain in the LSM flows #624

Merged
merged 2 commits into from
Sep 22, 2022
Merged

Require extra 8 GiB free space on the destination Storage Domain in the LSM flows #624

merged 2 commits into from
Sep 22, 2022

Commits on Sep 20, 2022

  1. core: create "MultipleStorageDomainsValidator" depending on the flow 

    Changing "createMultipleStorageDomainsValidator()" to be "protected"
in the "MoveOrCopyDiskCommand" class and overriding it in its derived
"LiveMigrateDiskCommand" class to add also the source Storage Domain ID.
Thus no need to check in the parent "MoveOrCopyDiskCommand" class
whether it's an LSM flow or not, in order to add also the source Storage
Domain ID to be checked by the created "MultipleStorageDomainsValidator".

Also removing the redundant "isDomainWithinThresholds()" destination
Storage Domain validation from the "LiveMigrateDiskCommand" class, since
it is correctly performed by the above "MultipleStorageDomainsValidator"
that validates both source & destination Storage Domains from its parent's
"MoveOrCopyDiskCommand::validateSpaceRequirements()".

Signed-off-by: Pavel Bar <pbar@redhat.com>
Bug-Url: https://bugzilla.redhat.com/2116309
    @barpavel @bennyz
    barpavel authored and bennyz committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    e6784cd View commit details
    Browse the repository at this point in the history

  2. core: Modify free space validation on destination Storage Domain in L… 

    …SM flow

Modify destination "StorageDomainValidator" getter to return a
dedicated validator that its "getTotalSizeForClonedDisk()" method
requires the additional 3 chunks (approximately 8 GiB) extra space
on the destination Storage Domain.
This is relevant only in LSM flow for cluster version 4.7 or above.

Signed-off-by: Pavel Bar <pbar@redhat.com>
Bug-Url: https://bugzilla.redhat.com/2116309
    @barpavel @bennyz
    barpavel authored and bennyz committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    408a636 View commit details
    Browse the repository at this point in the history