Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid logging secrets in Engine debug logs #646

Merged
merged 3 commits into from
Oct 14, 2022
Merged

Avoid logging secrets in Engine debug logs #646

merged 3 commits into from
Oct 14, 2022

Commits on Sep 22, 2022

  1. core: Add SecretValue class 

    This class allows wrapping values that shouldn’t be exposed in logs.
Its toString method returns just a placeholder and the real value must
be retrieved using getValue method.

This is useful for wrapping values such as TPM data, secure boot
NVRAM data, or passwords passed in cloud init, in order to prevent
them from exposing in DEBUG logs.  See the followup patches for
particular examples.
    @mz-pdm
    mz-pdm committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    26e7c14 View commit details
    Browse the repository at this point in the history

  2. core: Use SecretValue to protect TPM and secure boot data

    @mz-pdm
    mz-pdm committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    3a63752 View commit details
    Browse the repository at this point in the history

  3. core: Replace cloud-init password in debug logs 

    The password is currently replaced in meta data but it occurs in user
data.  Let’s replace it there too.
    @mz-pdm
    mz-pdm committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    9099867 View commit details
    Browse the repository at this point in the history