Offline RPM build, el9 enablement #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mwperina
commented
Sep 9, 2022
•
mwperina
commented
- Fix RPM build warnings around cinderlib
- Use oVirt buildcontainer image
- Use offline maven build
- Enable EL9 builds
- Install maven metadata without xmvn
mwperina
force-pushed
the
offline-rpm-build
branch
14 times, most recently
from
d6d43d7
to
da8aae6
Compare
michalskrivanek
requested review from
didib,
sandrobonazzola,
ahadas,
bennyz,
emesika,
michalskrivanek,
oliel,
sgratch,
smelamud and
ljelinkova
as code owners
|
yay! |
|
/ost |
|
Still need some work, maven poms are duplicated on different paths |
mwperina
force-pushed
the
offline-rpm-build
branch
2 times, most recently
from
f6b2be7
to
3b1b49c
Compare
|
/ost |
mwperina
force-pushed
the
offline-rpm-build
branch
12 times, most recently
from
51b6f51
to
cdd14bf
Compare
|
/ost |
mwperina
force-pushed
the
offline-rpm-build
branch
from
cdd14bf
to
c35a3e7
Compare
|
/ost |
1 similar comment
|
/ost |
Signed-off-by: Martin Perina <mperina@redhat.com>
Use oVirt buildcontainer image https://github.com/oVirt/buildcontainer
Signed-off-by: Martin Perina <mperina@redhat.com>
1. Use prefilled local maven repo from ovirt-engine-build-dependencies 2. Set offline mode for maven when invoked from RPM build 3. Remove maven cache from GH workflow Bug-Url: https://bugzilla.redhat.com/2005978 Signed-off-by: Martin Perina <mperina@redhat.com>
As we are not building using xmvn due to huge number of missing properly packaged dependencies we need to package maven metadata manually. Signed-off-by: Martin Perina <mperina@redhat.com>
michalskrivanek
force-pushed
the
offline-rpm-build
branch
from
ed99cc1
to
a278b73
Compare
michalskrivanek
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.