vm will be down when active snapshot does not have memory #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennyz
approved these changes
Sep 14, 2022
Previously, when trying-back/restoring a snapshot that doesn't have memory while the client requested to restore memory, the VM would have switched to Suspended state. Now, the VM is set to Suspended only when the active snapshot, the snapshot that was created by the trying-back/restore operation, is set with memory volumes. Otherwise, the VM is set to Down. See: oVirt/ovirt-web-ui#1629 Signed-off-by: Arik Hadas <ahadas@redhat.com>
ahadas
force-pushed
the
restore_memory
branch
from
9509e6a
to
14588e5
Compare
|
/ost |
sgratch
reviewed
Sep 15, 2022
.../bll/src/main/java/org/ovirt/engine/core/bll/snapshots/TryBackToAllSnapshotsOfVmCommand.java
Show resolved
Hide resolved
sgratch
added a commit
to sgratch/ovirt-engine
that referenced
this pull request
Sep 21, 2022
…ring purpose This is a followup fix for oVirt#653 (based on a comment review). by including the metadata volumes (in addition to memory ones) when checking if an active snapshot is set with memory for restoring.
ahadas
pushed a commit
that referenced
this pull request
Sep 21, 2022
…ring purpose This is a followup fix for #653 (based on a comment review). by including the metadata volumes (in addition to memory ones) when checking if an active snapshot is set with memory for restoring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when trying-back/restoring a snapshot that doesn't have memory while the client requested to restore memory, the VM would have switched to Suspended state.
Now, the VM is set to Suspended only when the active snapshot, the snapshot that was created by the trying-back/restore operation, is set with memory volumes. Otherwise, the VM is set to Down.
See: oVirt/ovirt-web-ui#1629
Signed-off-by: Arik Hadas ahadas@redhat.com