packaging: setup: Add keycloak_utils #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
didib
force-pushed
the
add-setup-keycloak_utils
branch
3 times, most recently
from
124aacb
to
8625bf7
Compare
didib
force-pushed
the
add-setup-keycloak_utils
branch
from
8625bf7
to
d87c846
Compare
with a single function, for now, keycloak_env_from_engine_conf. Change-Id: I8d03c2ce9ec8fdad8afd796317ff1e69ea55ecbe Signed-off-by: Yedidyah Bar David <didi@redhat.com>
didib
force-pushed
the
add-setup-keycloak_utils
branch
from
d87c846
to
6ad00eb
Compare
didib
added a commit
to didib/ovirt-dwh
that referenced
this pull request
Oct 18, 2022
With this flow: 1. Setup an engine with keycloak, no dwh/grafana 2. engine-setup --reconfigure-optional-components, enable dwh+grafana keycloak is already configured, but we do want to configure grafana to use keycloak. So remove the condition that we only do this if keycloak is not configured yet. Also support configuring grafana on a separate machine when keycloak on the engine machine is configured. Requires [1]. spec updated to require 4.5.4 engine-setup to get it. [1] oVirt/ovirt-engine#669 Change-Id: I019335c60f686d139da0e9368147e035db75ba37 Signed-off-by: Yedidyah Bar David <didi@redhat.com>
didib
added a commit
to didib/ovirt-dwh
that referenced
this pull request
Oct 24, 2022
With this flow: 1. Setup an engine with keycloak, no dwh/grafana 2. engine-setup --reconfigure-optional-components, enable dwh+grafana keycloak is already configured, but we do want to configure grafana to use keycloak. So remove the condition that we only do this if keycloak is not configured yet. Also support configuring grafana on a separate machine when keycloak on the engine machine is configured. Requires [1]. spec updated to require 4.5.4 engine-setup to get it. [1] oVirt/ovirt-engine#669 Change-Id: I019335c60f686d139da0e9368147e035db75ba37 Signed-off-by: Yedidyah Bar David <didi@redhat.com>
sandrobonazzola
pushed a commit
to didib/ovirt-dwh
that referenced
this pull request
Nov 28, 2023
With this flow: 1. Setup an engine with keycloak, no dwh/grafana 2. engine-setup --reconfigure-optional-components, enable dwh+grafana keycloak is already configured, but we do want to configure grafana to use keycloak. So remove the condition that we only do this if keycloak is not configured yet. Also support configuring grafana on a separate machine when keycloak on the engine machine is configured. Requires [1]. spec updated to require 4.5.4 engine-setup to get it. [1] oVirt/ovirt-engine#669 Change-Id: I019335c60f686d139da0e9368147e035db75ba37 Signed-off-by: Yedidyah Bar David <didi@redhat.com>
sandrobonazzola
pushed a commit
to didib/ovirt-dwh
that referenced
this pull request
Jul 12, 2024
With this flow: 1. Setup an engine with keycloak, no dwh/grafana 2. engine-setup --reconfigure-optional-components, enable dwh+grafana keycloak is already configured, but we do want to configure grafana to use keycloak. So remove the condition that we only do this if keycloak is not configured yet. Also support configuring grafana on a separate machine when keycloak on the engine machine is configured. Requires [1]. spec updated to require 4.5.4 engine-setup to get it. [1] oVirt/ovirt-engine#669 Change-Id: I019335c60f686d139da0e9368147e035db75ba37 Signed-off-by: Yedidyah Bar David <didi@redhat.com>
sandrobonazzola
pushed a commit
to didib/ovirt-dwh
that referenced
this pull request
Jul 12, 2024
With this flow: 1. Setup an engine with keycloak, no dwh/grafana 2. engine-setup --reconfigure-optional-components, enable dwh+grafana keycloak is already configured, but we do want to configure grafana to use keycloak. So remove the condition that we only do this if keycloak is not configured yet. Also support configuring grafana on a separate machine when keycloak on the engine machine is configured. Requires [1]. spec updated to require 4.5.4 engine-setup to get it. [1] oVirt/ovirt-engine#669 Change-Id: I019335c60f686d139da0e9368147e035db75ba37 Signed-off-by: Yedidyah Bar David <didi@redhat.com>
sandrobonazzola
pushed a commit
to oVirt/ovirt-dwh
that referenced
this pull request
Jul 12, 2024
With this flow: 1. Setup an engine with keycloak, no dwh/grafana 2. engine-setup --reconfigure-optional-components, enable dwh+grafana keycloak is already configured, but we do want to configure grafana to use keycloak. So remove the condition that we only do this if keycloak is not configured yet. Also support configuring grafana on a separate machine when keycloak on the engine machine is configured. Requires [1]. spec updated to require 4.5.4 engine-setup to get it. [1] oVirt/ovirt-engine#669 Change-Id: I019335c60f686d139da0e9368147e035db75ba37 Signed-off-by: Yedidyah Bar David <didi@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with a single function, for now, keycloak_env_from_engine_conf.
Change-Id: I8d03c2ce9ec8fdad8afd796317ff1e69ea55ecbe
Signed-off-by: Yedidyah Bar David didi@redhat.com