webadmin: Add validation to new template #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In PR [1], the validation of a new template was removed from the UI in assumption that the backend can validate the template properly. However, the backend does not contain validation for the name and if the name is not provided, it fails on inserting null to a not null database column. This patch adds the name validation back to the fronted. 1: oVirt#621
mz-pdm
approved these changes
Sep 23, 2022
|
/ost |
michalskrivanek
approved these changes
Sep 23, 2022
michalskrivanek
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #621, the validation of a new template was removed from the UI in assumption that the backend can validate the template properly. However, the backend does not contain validation for the name and if the name is not provided, it fails on inserting null to a not null database column. This patch adds the name validation back to the fronted.