Fix padding issue when decrypting OVN provider password #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have added new encryption/decryption method for OVN provider password as a part of oVirt#677 Unfortunately there was an error during password decryptio due to the implementation differencies between Python and OpenJDK. Signed-off-by: Martin Perina <mperina@redhat.com>
mwperina
requested review from
ahadas,
bennyz,
emesika,
michalskrivanek,
oliel,
sgratch,
smelamud,
didib and
ljelinkova
as code owners
|
/ost |
This was referenced Sep 27, 2022
|
Don't we still need the change in ovirtproviderovn.py? Shouldn't it store the password with the |
that's been merged already:) |
mz-pdm
reviewed
Sep 27, 2022
| if (newCipher) { | ||
| cipher = Cipher.getInstance("RSA/ECB/OAEPWITHSHA-256ANDMGF1PADDING"); | ||
| // By default Oracle standard security provider uses MFG1 instantiated with SHA-1, SHA-256 is used only | ||
| // ti has the label, so we need to enforce using SHA-256 |
Ah nevermind then :) |
michalskrivanek
approved these changes
Sep 27, 2022
|
verified no more provider errors in engine.log |
mz-pdm
approved these changes
Sep 27, 2022
|
tested on el9 with oVirt/ovirt-system-tests#279 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have added new encryption/decryption method for OVN provider password
as a part of #677
Unfortunately there was an error during password decryptio due to the
implementation differencies between Python and OpenJDK.
Signed-off-by: Martin Perina mperina@redhat.com