-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix padding issue when decrypting OVN provider password #683
Fix padding issue when decrypting OVN provider password #683
Conversation
We have added new encryption/decryption method for OVN provider password as a part of oVirt#677 Unfortunately there was an error during password decryptio due to the implementation differencies between Python and OpenJDK. Signed-off-by: Martin Perina <mperina@redhat.com>
/ost |
Don't we still need the change in ovirtproviderovn.py? Shouldn't it store the password with the |
that's been merged already:) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, AFAICT, except for the typo in the source comment.
if (newCipher) { | ||
cipher = Cipher.getInstance("RSA/ECB/OAEPWITHSHA-256ANDMGF1PADDING"); | ||
// By default Oracle standard security provider uses MFG1 instantiated with SHA-1, SHA-256 is used only | ||
// ti has the label, so we need to enforce using SHA-256 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"ti"?
Ah nevermind then :) |
verified no more provider errors in engine.log |
tested on el9 with oVirt/ovirt-system-tests#279 |
We have added new encryption/decryption method for OVN provider password
as a part of #677
Unfortunately there was an error during password decryptio due to the
implementation differencies between Python and OpenJDK.
Signed-off-by: Martin Perina mperina@redhat.com