-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix ansible lint seperate commits #684
fix ansible lint seperate commits #684
Commits on Oct 26, 2022
-
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=2100137 including fixes for: - use FQCN for builtin actions - missing starting space in comment - jinja2 spacing could be improved - line too long - no new line character at the end of file - trailing spaces - too many spaces before colon - too many spaces after colon - too many blank lines - all names should start with an uppercase letter - truthy value should be one of (yaml[truthy]) - wrong indentation
Configuration menu - View commit details
-
Copy full SHA for 98317c1 - Browse repository at this point
Copy the full SHA 98317c1View commit details -
fix ansible lint: risky file permissions:
'File permissions unset or incorrect'
Configuration menu - View commit details
-
Copy full SHA for b78c284 - Browse repository at this point
Copy the full SHA b78c284View commit details -
fix ansible lint: risky-shell-pipe:
'Shells that use pipes should set the pipefail option'
Configuration menu - View commit details
-
Copy full SHA for 36fc63b - Browse repository at this point
Copy the full SHA 36fc63bView commit details -
- role-name: Role name <role-name> does not match ``^*$`` pattern. - name: All tasks should be named. (name[missing])
Configuration menu - View commit details
-
Copy full SHA for b8cc1b2 - Browse repository at this point
Copy the full SHA b8cc1b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for d6d253c - Browse repository at this point
Copy the full SHA d6d253cView commit details -
fix ansible lint: no-changed-when:
'Commands should not change things if nothing needs doing' Since the tag 'skip_ansible_lint oVirt#301' doesn't work and '# noqa no-changed-when' cannot be set on code blocks, adding it to skip list
Configuration menu - View commit details
-
Copy full SHA for 243fc68 - Browse repository at this point
Copy the full SHA 243fc68View commit details -
fix ansible lints: using command
- command-instead-of-module: systemctl used in place of systemd module (+ merged tasks), rpm used in place of yum or rpm_key module - command-instead-of-shell: Use shell only when shell functionality is required
Configuration menu - View commit details
-
Copy full SHA for 0b19b51 - Browse repository at this point
Copy the full SHA 0b19b51View commit details -
fix ansible lint: ignore-errors:
The error 'Use failed_when and specify error conditions instead of using ignore_errors' was handled by adding '# noqa ignore-errors' tag, since failure in these tasks shouldn't block from continuing the execution of the role
Configuration menu - View commit details
-
Copy full SHA for 329a250 - Browse repository at this point
Copy the full SHA 329a250View commit details -
Tasks that run when changed should likely be handlers
Configuration menu - View commit details
-
Copy full SHA for 2280aea - Browse repository at this point
Copy the full SHA 2280aeaView commit details -
Configuration menu - View commit details
-
Copy full SHA for fc15f6b - Browse repository at this point
Copy the full SHA fc15f6bView commit details -
Configuration menu - View commit details
-
Copy full SHA for bb6ca23 - Browse repository at this point
Copy the full SHA bb6ca23View commit details -
fix ansible lint: template-instead-of-copy:
'Templated files should use template instead of copy'
Configuration menu - View commit details
-
Copy full SHA for 6ebc06f - Browse repository at this point
Copy the full SHA 6ebc06fView commit details -
use argv with command instead of quoting inside the command
fixed in all places that replaced shell with command
Configuration menu - View commit details
-
Copy full SHA for 9545e85 - Browse repository at this point
Copy the full SHA 9545e85View commit details -
- use FQCN for builtin module actions (include_tasks, import_tasks) - Use FQCN for module actions
Configuration menu - View commit details
-
Copy full SHA for efe235b - Browse repository at this point
Copy the full SHA efe235bView commit details -
fix ansible lint: ignore risky-shell-pipe
Ignoring because when using 'set -o pipefail &&' the task fails due to non zero return code
Configuration menu - View commit details
-
Copy full SHA for 88febb7 - Browse repository at this point
Copy the full SHA 88febb7View commit details