fix ansible lint seperate commits #684

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=2100137 including fixes for: - use FQCN for builtin actions - missing starting space in comment - jinja2 spacing could be improved - line too long - no new line character at the end of file - trailing spaces - too many spaces before colon - too many spaces after colon - too many blank lines - all names should start with an uppercase letter - truthy value should be one of (yaml[truthy]) - wrong indentation

'File permissions unset or incorrect'

'Shells that use pipes should set the pipefail option'

- role-name: Role name <role-name> does not match ``^*$`` pattern. - name: All tasks should be named. (name[missing])

'Commands should not change things if nothing needs doing' Since the tag 'skip_ansible_lint oVirt#301' doesn't work and '# noqa no-changed-when' cannot be set on code blocks, adding it to skip list

- command-instead-of-module: systemctl used in place of systemd module (+ merged tasks), rpm used in place of yum or rpm_key module - command-instead-of-shell: Use shell only when shell functionality is required

The error 'Use failed_when and specify error conditions instead of using ignore_errors' was handled by adding '# noqa ignore-errors' tag, since failure in these tasks shouldn't block from continuing the execution of the role

Tasks that run when changed should likely be handlers

'Templated files should use template instead of copy'

fixed in all places that replaced shell with command

- use FQCN for builtin module actions (include_tasks, import_tasks) - Use FQCN for module actions

Ignoring because when using 'set -o pipefail &&' the task fails due to non zero return code

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix ansible lint seperate commits #684

fix ansible lint seperate commits #684

Commits on Oct 26, 2022