Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] further refresh_token debugging #685

Closed
wants to merge 2 commits into from
Closed

[WIP] further refresh_token debugging #685

wants to merge 2 commits into from

Conversation

michalskrivanek
Copy link
Member

No description provided.

@michalskrivanek michalskrivanek changed the title [WIP] further rfresh_token debugging [WIP] further refresh_token debugging Sep 28, 2022
@michalskrivanek
Copy link
Member Author

/ost

2 similar comments
@michalskrivanek
Copy link
Member Author

/ost

@michalskrivanek
Copy link
Member Author

/ost

@michalskrivanek
Copy link
Member Author

/ost

1 similar comment
@michalskrivanek
Copy link
Member Author

/ost

@michalskrivanek
Copy link
Member Author

@mwperina I think

                if (refreshToken != null) {
                    ExternalOIDCService.logout(ssoContext, refreshToken);
                }

part makes sense to merge. It eliminates the exception in keycloak, and doesn't affect anything else as it fails to log out there anyway. It doesn't help with proper invalidation when there are multiple sessions with same keycloak user...that would likely need much deeper change in AAA code

@michalskrivanek
Copy link
Member Author

replaced by #704

@ahadas ahadas closed this Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahadas ahadas Awaiting requested review from ahadas ahadas is a code owner

@bennyz bennyz Awaiting requested review from bennyz bennyz is a code owner

@emesika emesika Awaiting requested review from emesika emesika is a code owner

@mwperina mwperina Awaiting requested review from mwperina mwperina is a code owner

@oliel oliel Awaiting requested review from oliel

@sgratch sgratch Awaiting requested review from sgratch sgratch is a code owner

@smelamud smelamud Awaiting requested review from smelamud smelamud is a code owner

@didib didib Awaiting requested review from didib didib is a code owner

@ljelinkova ljelinkova Awaiting requested review from ljelinkova

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@michalskrivanek @ahadas