core: add callback to RemoveDiskCommand #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkemel
requested review from
bennyz,
ahadas,
emesika,
mwperina,
michalskrivanek,
oliel,
sgratch,
smelamud,
didib and
ljelinkova
as code owners
bennyz
reviewed
Oct 24, 2022
...ager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/RemoveDiskCommand.java
Show resolved
Hide resolved
mkemel
force-pushed
the
db_sync_for_remove_image
branch
from
b6de594
to
66024d0
Compare
|
/ost |
bennyz
reviewed
Oct 25, 2022
...ager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/RemoveDiskCommand.java
Outdated
Show resolved
Hide resolved
mkemel
force-pushed
the
db_sync_for_remove_image
branch
from
66024d0
to
dcebd1c
Compare
|
/ost |
ahadas
approved these changes
Oct 25, 2022
Adding callback to RemoveDiskCommand so that it would wait for RemoveImageCommand to finish, incl. removing the image from the DB. This fixes an issue where RemoveDisk job was marked as FINISHED before the image was actually removed from the DB. Bug-Url: https://bugzilla.redhat.com/2137207
ahadas
force-pushed
the
db_sync_for_remove_image
branch
from
dcebd1c
to
d7915c4
Compare
|
/ost |
bennyz
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding callback to RemoveDiskCommand so that it would wait for RemoveImageCommand to finish, incl. removing the image from the DB. This fixes an issue where RemoveDisk job was marked as FINISHED before the image was actually removed from the DB.
Bug-Url: https://bugzilla.redhat.com/2137207