Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport: Add missing copies of TPM parameters #724

Merged
merged 3 commits into from
Nov 2, 2022
Merged

Backport: Add missing copies of TPM parameters #724

merged 3 commits into from
Nov 2, 2022

Commits on Nov 2, 2022

  1. core: Add missing items in VmManagementParametersBase copy constructor

    @mz-pdm @mwperina
    mz-pdm authored and mwperina committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    db7bbcf View commit details
    Browse the repository at this point in the history

  2. frontend: Add TPM parameter when cloning a VM from a snapshot 

    When cloning a VM from a snapshot, isTpmEnabled parameter is not set
in VmSnapshotListModel, resulting in a loss of the TPM device and an
error if the TPM device is mandatory, i.e. for VMs with newer Windows
versions as the guest OS.  This patch fixes the omission and adds the
corresponding parameter.

Bug-Url: oVirt#702
Bug-Url: https://bugzilla.redhat.com/2136180
    @mz-pdm @mwperina
    mz-pdm authored and mwperina committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    60e069d View commit details
    Browse the repository at this point in the history

  3. core: Update TPM device in parameters 

    TPM device is not updated in
VmDeviceUtils.updateVmDevicesInParameters.  This results in omitting
the TPM device at least when exporting a VM to a data domain and an
error when the TPM device is mandatory, i.e. for VMs with a modern
Windows guest OS.  This patch fixes the omission and sets the
corresponding parameter.

Bug-Url: oVirt#702
    @mz-pdm @mwperina
    mz-pdm authored and mwperina committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    cff4010 View commit details
    Browse the repository at this point in the history