Validate NUMA support and sockets equal to NUMA nodes for resize and pin #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liranr23
requested review from
sgratch,
ljelinkova,
almusil,
ahadas,
bennyz,
emesika,
mwperina,
michalskrivanek,
oliel and
didib
as code owners
liranr23
commented
Feb 14, 2022
...dules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/NumaPolicyUnit.java
Outdated
Show resolved
Hide resolved
...dules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/NumaPolicyUnit.java
Outdated
Show resolved
Hide resolved
ljelinkova
reviewed
Feb 14, 2022
...badmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Outdated
Show resolved
Hide resolved
...dules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/NumaPolicyUnit.java
Outdated
Show resolved
Hide resolved
liranr23
force-pushed
the
valid_equal_numa_autopin
branch
from
7f61d6e
to
437a831
Compare
liranr23
changed the title
|
/ost |
ljelinkova
reviewed
Jun 22, 2022
Well, it relates to both. But it felt to me more related to NUMA. This will also solve two bugs (not allowing resize and pin on host without NUMA support and, making sure the host hardware is correct with sockets==numa nodes. I can switch the equality check to |
|
Yes, I really think it would make the code more readable when all cpu topology checks are in one place. |
liranr23
force-pushed
the
valid_equal_numa_autopin
branch
from
437a831
to
de88a9c
Compare
done |
|
/ost |
liranr23
force-pushed
the
valid_equal_numa_autopin
branch
from
de88a9c
to
10bff8e
Compare
|
I split the PR into 2 separate commit as discussed offline with Lucia. |
|
/ost |
ljelinkova
approved these changes
Jun 24, 2022
|
/ost |
1 similar comment
|
/ost |
|
@ahadas, any comments or can it be merged? |
ahadas
reviewed
Jul 14, 2022
...dules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/NumaPolicyUnit.java
Show resolved
Hide resolved
liranr23
force-pushed
the
valid_equal_numa_autopin
branch
2 times, most recently
from
a6e57d0
to
37927ad
Compare
|
/ost |
1 similar comment
|
/ost |
ahadas
reviewed
Jul 19, 2022
...dules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/NumaPolicyUnit.java
Outdated
Show resolved
Hide resolved
liranr23
force-pushed
the
valid_equal_numa_autopin
branch
from
37927ad
to
49b89a1
Compare
ahadas
approved these changes
Jul 20, 2022
When running a VM with 'Resize and Pin' CPU pinning policy, the algorithm expects the host to have the same number of sockets and NUMA nodes. That way the algorithm fits the topology and leaves the first core on each socket free to the host. This patch filters out hosts that don't have an equal number of sockets and NUMA nodes when trying to run a VM with CPU pinning policy `Resize and Pin`. Change-Id: Icdc1ac910eb733f6edd861d0505fb90a581224b5 Bug-Url: https://bugzilla.redhat.com/1955388 Signed-off-by: Liran Rotenberg <lrotenbe@redhat.com>
When having `Resize and Pin NUMA` VM that tries to schedule on a host, it shouldn't run on a host without NUMA support. This patch filter these host in the above scenario. Change-Id: I41ae6d54625a2c14b749f6393c29059cbd53a6d7 Bug-Url: https://bugzilla.redhat.com/2056950 Signed-off-by: Liran Rotenberg <lrotenbe@redhat.com>
ahadas
force-pushed
the
valid_equal_numa_autopin
branch
from
49b89a1
to
be91450
Compare
|
/ost |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running a VM with 'Resize and Pin' CPU pinning policy, the algorithm
expects the host to have the same number of sockets and NUMA nodes. That
way the algorithm fits the topology and leaves the first core on each
socket free to the host.
This patch filters out hosts that don't have an equal number of sockets
and NUMA nodes in the NUMA filter policy when trying to run a VM with CPU
pinning policy
Resize and Pin.Change-Id: Icdc1ac910eb733f6edd861d0505fb90a581224b5
Bug-Url: https://bugzilla.redhat.com/1955388
Signed-off-by: Liran Rotenberg lrotenbe@redhat.com