-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate NUMA support and sockets equal to NUMA nodes for resize and pin #76
Conversation
...dules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/NumaPolicyUnit.java
Outdated
Show resolved
Hide resolved
...dules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/NumaPolicyUnit.java
Outdated
Show resolved
Hide resolved
...badmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Outdated
Show resolved
Hide resolved
...dules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/NumaPolicyUnit.java
Outdated
Show resolved
Hide resolved
7f61d6e
to
437a831
Compare
/ost |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why already handle some topology requirements for resize and pin in CpuTopologyPolicyUnit
- what about adding it there so that it is in one place?
Well, it relates to both. But it felt to me more related to NUMA. This will also solve two bugs (not allowing resize and pin on host without NUMA support and, making sure the host hardware is correct with sockets==numa nodes. I can switch the equality check to |
Yes, I really think it would make the code more readable when all cpu topology checks are in one place. |
437a831
to
de88a9c
Compare
done |
/ost |
de88a9c
to
10bff8e
Compare
I split the PR into 2 separate commit as discussed offline with Lucia. |
/ost |
/ost |
1 similar comment
/ost |
@ahadas, any comments or can it be merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please also make sure the first commit has everything that is needed to compile (it seems you added a missing import in the second commit)
...dules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/NumaPolicyUnit.java
Show resolved
Hide resolved
a6e57d0
to
37927ad
Compare
/ost |
1 similar comment
/ost |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks correct, minor comment inside
...dules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/NumaPolicyUnit.java
Outdated
Show resolved
Hide resolved
37927ad
to
49b89a1
Compare
When running a VM with 'Resize and Pin' CPU pinning policy, the algorithm expects the host to have the same number of sockets and NUMA nodes. That way the algorithm fits the topology and leaves the first core on each socket free to the host. This patch filters out hosts that don't have an equal number of sockets and NUMA nodes when trying to run a VM with CPU pinning policy `Resize and Pin`. Change-Id: Icdc1ac910eb733f6edd861d0505fb90a581224b5 Bug-Url: https://bugzilla.redhat.com/1955388 Signed-off-by: Liran Rotenberg <lrotenbe@redhat.com>
When having `Resize and Pin NUMA` VM that tries to schedule on a host, it shouldn't run on a host without NUMA support. This patch filter these host in the above scenario. Change-Id: I41ae6d54625a2c14b749f6393c29059cbd53a6d7 Bug-Url: https://bugzilla.redhat.com/2056950 Signed-off-by: Liran Rotenberg <lrotenbe@redhat.com>
49b89a1
to
be91450
Compare
/ost |
When running a VM with 'Resize and Pin' CPU pinning policy, the algorithm
expects the host to have the same number of sockets and NUMA nodes. That
way the algorithm fits the topology and leaves the first core on each
socket free to the host.
This patch filters out hosts that don't have an equal number of sockets
and NUMA nodes in the NUMA filter policy when trying to run a VM with CPU
pinning policy
Resize and Pin
.Change-Id: Icdc1ac910eb733f6edd861d0505fb90a581224b5
Bug-Url: https://bugzilla.redhat.com/1955388
Signed-off-by: Liran Rotenberg lrotenbe@redhat.com