Set new templates with specified vm-init #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahadas
requested review from
sgratch,
ljelinkova,
bennyz,
emesika,
mwperina,
michalskrivanek,
oliel,
smelamud and
didib
as code owners
ahadas
force-pushed
the
add_template_vm_init
branch
from
b825d32
to
3181564
Compare
Previously, the backend (AddVmTemplate) set new templates with the vm-init configuration of the VM that they were created from. This prevented users from creating templates with modified vm-init configuration or without vm- init configuration from VMs that are set with vm-init. Users could either change the VM first or modify the created template to achieve this. Now, the backend respects the vm-init configuration that is specified by clients. While the handling of vm-init in REST-API works well, the UI did not pass the vm-init configuration of the VM that templates were created from. Therefore, the webadmin is changed to load the vm-init configuration of the VM that a template is created from and pass it to the backend now. Signed-off-by: Arik Hadas <ahadas@redhat.com>
ahadas
force-pushed
the
add_template_vm_init
branch
from
3181564
to
4448449
Compare
|
/ost |
ljelinkova
reviewed
Dec 1, 2022
...odules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
Show resolved
Hide resolved
smelamud
approved these changes
Dec 1, 2022
ljelinkova
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the backend (AddVmTemplate) set new templates with the vm-init configuration of the VM that they were created from. This prevented users from creating templates with modified vm-init configuration or without vm- init configuration from VMs that are set with vm-init. Users could either change the VM first or modify the created template to achieve this.
Now, the backend respects the vm-init configuration that is specified by clients. While the handling of vm-init in REST-API works well, the UI did not pass the vm-init configuration of the VM that templates were created from. Therefore, the webadmin is changed to load the vm-init configuration of the VM that a template is created from and pass it to the backend now.