Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix remove image (backport) #772

Merged
merged 2 commits into from
Dec 7, 2022
Merged

Fix remove image (backport) #772

merged 2 commits into from
Dec 7, 2022

Commits on Dec 6, 2022

  1. core: fix execution of RemoveImage 

    RemoveImage now attaches the created async task to itself rather than to
its parent command and its EndProcedure type is changed to COMMAND_MANAGED.
With these changes, first the execution of RemoveImage is completed and
then its parent's callback detects it and completes the execution of the
parent command.

Signed-off-by: Arik Hadas <ahadas@redhat.com>
    @ahadas
    ahadas committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    c05cc73 View commit details
    Browse the repository at this point in the history

  2. core: fix async task-less execution of remove-image 

    RemoveImage may lack async tasks when:
1. The image doesn't exist
2. There's a failure during delete image

With these changes, the image is removed from the database (rather than
staying in LOCKED state) and the command would finish successfully in
the first case, and in the second case the command end with failure and
the image switches to ILLEGAL state.

Signed-off-by: Arik Hadas <ahadas@redhat.com>
    @ahadas
    ahadas committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    b7a957e View commit details
    Browse the repository at this point in the history