Allow OVA import when origin is null and destination is block SD #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shubha Kulkarni <shubha.kulkarni@oracle.com>
shubhaOracle
requested review from
ahadas,
bennyz,
emesika,
mwperina,
michalskrivanek,
oliel,
sgratch,
smelamud,
didib and
ljelinkova
as code owners
ahadas
reviewed
Dec 11, 2022
| @@ -372,7 +372,8 @@ private void adjustKVMDataForBlockSD() { | |||
| // can be larger then the actual size. | |||
| // Separately, setting the Volume Type to Preallocated avoids Sparseness when the | |||
| // Destination is a Block SD | |||
| if (getVm().getOrigin() == OriginType.KVM | |||
| // Allow this workaround for Vms that do not have origin set | |||
| if ((getVm().getOrigin() == null || getVm().getOrigin() == OriginType.KVM) | |||
There was a problem hiding this comment.
note that with the fix for #745, we shouldn't get VMs with origin == null anymore
but what's the scenario that you try to address here - you import an OVA that was not exported from oVirt, there's a block storage domain is used as a destination and the conversion fails due to lack of space?
raw volumes are already supposed to be set as preallocated in case of OVA import so this change is not clear to me. could you please elaborate on the issue? is it reproducible with oVirt 4.5?
There was a problem hiding this comment.
Thanks for the details. With the latest oVirt install that has the fix for #745, the issue was not reproducible. We can close this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow OVA import when origin is null and destination is block SD.
Issue:
Importing certain OVA image fails with "No space left on device".
Certain OVA images exported from VMware fail to import because vm origin was not set.
Fix:
Check for vm.origin null when importing ova to block storage
Signed-off-by: Shubha Kulkarni shubha.kulkarni@oracle.com