B2151549 ansible runner artifacts not cleaned up #786
Conversation
dangel101
commented
Jan 1, 2023
dangel101
commented
- add debug logging to AnsibleRunnerCleanUpService
- executing ansible runner artifacts clean up at fixed rate
dangel101
requested review from
ahadas,
bennyz,
emesika,
mwperina,
michalskrivanek,
oliel,
sgratch,
smelamud,
didib and
ljelinkova
as code owners
dangel101
force-pushed
the
B2151549_ansible_runner_artifacts_not_cleaned_up
branch
from
e7faf00
to
27af0bd
Compare
| @@ -40,14 +40,17 @@ public void scheduleJob() { | |||
| final int HOURS_TO_MINUTES = 60; | |||
| long intervalInMinutes = Math.round(interval * HOURS_TO_MINUTES); | |||
|
|
|||
| executor.schedule(this::checkExecutionTimeStamp, | |||
| executor.scheduleAtFixedRate(this::checkExecutionTimeStamp, | |||
There was a problem hiding this comment.
Wouldn't it be better to use scheduleWithFixedDelay the same as we use for other periodical services?
https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/ScheduledExecutorService.html
There was a problem hiding this comment.
the functions are pretty similar,
I thought it'd be better to trigger each execution at the same time, as FixedRate does
FixedDelay starts to count the time after the last execution was finished.
For the clean up service there shouldn't be much of a difference between them, so if you prefer that it would be similar to the other services I can change it
There was a problem hiding this comment.
Hmm, I'd say it's safer to trigger next execution only after the 1st one finishes (we can't be sure what users will enter into the engine-config options) :-)
dangel101
force-pushed
the
B2151549_ansible_runner_artifacts_not_cleaned_up
branch
from
27af0bd
to
38ba1e1
Compare
Ansible-Runner artifacts are cleaned up periodically according to the properties configured in engine-config: AnsibleRunnerArtifactsLifetimeInDays: How many days artifacts will be kept before they are cleaned up AnsibleRunnerArtifactsCleanupCheckTimeInHours: The periodic time to execute the clean up Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=2151549 Signed-off-by: dangel101 <dangel101@gmail.com>
mwperina
force-pushed
the
B2151549_ansible_runner_artifacts_not_cleaned_up
branch
from
38ba1e1
to
433e2dc
Compare
