engine: Remove taa-no from Secure Skylake Server #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The host with Secure Intel Icelake Server Family become non operational because it does not provide "taa-no" CPU feature even though the following command indicates that the host is not vulnerable. cat /sys/devices/system/cpu/vulnerabilities/tsx_async_abort Not affected It is possible that this flag is not reported on systems that are not vulnerable anymore. We disable TSX in our CPU definition (we use Icelake-Server-noTSX) so it is not a security risk if we leave the requirement for "taa-no" CPU feature. Bug-Url: https://github.com/oVirt/ovirt-engine/issues/2184623 Signed-off-by: Lucia Jelinkova <ljelinko@redhat.com>
ljelinkova
force-pushed
the
remove-taa-no
branch
from
0aa3d4f
to
db7480d
Compare
|
it's not ideal to remove things for the odd case of someone explicitly enabling tsx and relying on taa. but it's IMHO such a corner case that it's not worth extra effort |
|
LGTM |
|
/ost |
|
I am guessing you meant to link https://bugzilla.redhat.com/show_bug.cgi?id=2184623 :) |
ahadas
reviewed
Apr 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The host with Secure Intel Icelake Server Family become non operational because it does not provide "taa-no" CPU feature even though the following command indicates that the host is not vulnerable.
It is possible that this flag is not reported on systems that are not vulnerable anymore. We disable TSX in our CPU definition (we use Icelake-Server-noTSX) so it is not a security risk if we leave the requirement for "taa-no" CPU feature.
Bug-Url: https://bugzilla.redhat.com/2184623