Fix NPE when picking host for transfer-image #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When picking a host for transfer-image job, we filter hosts that are UP and then process the data they reported on storage domains without checking whether the host actually reported this data. It can happen that hosts are UP and still have not reported data on storage domains, in which case the data is null, resulting in an NPE in the transfer-image flow. This patch changes the predicate that is used to filter hosts for transfer-image, adding a null-check to avoid that NPE. Bug-Url: https://bugzilla.redhat.com/2203132 Signed-off-by: Arik Hadas <ahadas@redhat.com>
bennyz
approved these changes
May 21, 2023
ahadas
requested review from
emesika,
mwperina,
michalskrivanek,
oliel,
sgratch,
smelamud,
didib and
ljelinkova
as code owners
|
/ost |
mwperina
approved these changes
May 21, 2023
ack, I planned to drop this commit after seeing that OST passes but if we're ok with commenting it out, I'd change the commit message |
The call to ansible-lint is commented out until we fix it Filed issue: oVirt#851 Signed-off-by: Arik Hadas <ahadas@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When picking a host for transfer-image job, we filter hosts that are UP and then process the data they reported on storage domains without checking whether the host actually reported this data. It can happen that hosts are UP and still have not reported data on storage domains, in which case the data is null, resulting in an NPE in the transfer-image flow.
This patch changes the predicate that is used to filter hosts for transfer-image, adding a null-check to avoid that NPE.
Bug-Url: https://bugzilla.redhat.com/2203132