Do not change qcow+preallocated volumes when moving disks #875
Conversation
Base volumes can be of QCOW format and preallocated type when the disk is set with incremental-backup enabled. When moving disks, we now propagate the incremental-backup settings forward to CreateVolume so it will keep these volumes preallocated on the destination storage domain. Bug-Url: https://bugzilla.redhat.com/2211608 Signed-off-by: Arik Hadas <ahadas@redhat.com>
ahadas
requested review from
bennyz,
emesika,
mwperina,
michalskrivanek,
oliel,
sgratch,
smelamud,
didib and
ljelinkova
as code owners
@bennyz that's my theory but I didn't check it yet (FYI) |
Makes sense to me, worth a try |
|
verified, this change indeed keeps the base volume with qcow+preallocated configuration on the host side and also converts base volume that have been switched to qcow+sparse back to qcow+preallocated when they move again while the guest keeps functioning well. now need to see what's going on with OST... |
|
/ost |
Base volumes can be of QCOW format and preallocated type when the disk is set with incremental-backup enabled. When moving disks, we now propagate the incremental-backup settings forward to CreateVolume so it will keep these volumes preallocated on the destination storage domain.
Bug-Url: https://bugzilla.redhat.com/2211608