Make the OvfOvirtReader disk read more robust #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liranr23
requested review from
ahadas,
bennyz,
emesika,
mwperina,
michalskrivanek,
oliel,
sgratch,
smelamud,
didib and
ljelinkova
as code owners
mwperina
reviewed
Nov 14, 2023
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfOvirtReader.java
Outdated
Show resolved
Hide resolved
liranr23
force-pushed
the
ova_robust_read
branch
from
ff7f34a
to
5faa9f8
Compare
ahadas
force-pushed
the
ova_robust_read
branch
from
5faa9f8
to
3f3effc
Compare
Signed-off-by: Arik Hadas <ahadas@redhat.com>
ahadas
force-pushed
the
ova_robust_read
branch
from
3f3effc
to
c652570
Compare
Some OVA files might miss one (or more) of the attributes. This might result in NullPointerException. This change will make the disk read to be more robust and prevent the exception. Signed-off-by: Liran Rotenberg <lrotenbe@redhat.com>
ahadas
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some OVA files might miss one (or more) of the attributes. This might result in
NullPointerException. This change will make the disk read to be more robust and prevent the exception.The issue seen in user list here.