"Export to CSV" functionality for main tables in oVirt Administration Portal #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandrobonazzola
force-pushed
the
csv-export
branch
from
f4aad03
to
b1207e0
Compare
JiejunLi
suggested changes
May 8, 2024
There was a problem hiding this comment.
If the platform language is set to non English, CSV will output ‘????’ in columns。
There was a problem hiding this comment.
@JiejunLi
Intersting. I verified several different languages - works fine for me. Will try to dig more into it
There was a problem hiding this comment.
Hi @JiejunLi. I cannot reproduce the issue. The csv file is generated using utf-8 encoding. Could you please confirm that the tool you use to see the csv file properly recognizes (or allows to specify manually) the "utf-8" encoding. If so, then could you please clarify what language do you verify?
Also could you send me the csv file?
sermakov-orion
force-pushed
the
csv-export
branch
from
b1207e0
to
0a9eb1a
Compare
sandrobonazzola
force-pushed
the
csv-export
branch
from
0a9eb1a
to
561b46e
Compare
sandrobonazzola
requested review from
dupondje and
BrooklynDewolf
and removed request for
ljelinkova
… Portal Signed-off-by: Stepan Ermakov <sermakov@orionsoft.ru> This feature adds new menu item "Export to CSV" for the following tables of oVirt Administration Portal Compute * Virtual Machines * Templates * Pools * Hosts * Data Centers Network * Networks Storage * Domains * Volumes * Disks Events The menu item allows to export current content (taking in to account current localization, columns visibility, sort order, filter) of the selected table into CSV. And initiates automatic download of the created CSV file. Known limitation: not more than 10,000 can be exported.
sandrobonazzola
force-pushed
the
csv-export
branch
from
561b46e
to
02aff0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Export to CSV" functionality for main tables in oVirt Administration Portal
Signed-off-by: Stepan Ermakov sermakov@orionsoft.ru
Changes introduced with this PR
This feature adds new menu item "Export to CSV" for the following tables of oVirt Administration Portal:
Compute
Network
Storage
Events
The menu item allows to export current content (taking in to account current localization, columns visibility, sort order, filter) of the selected table into CSV. And initiates automatic download of the created CSV file.
Known limitation: not more than 10,000 rows can be exported.
vms.2023-12-05.09-07.csv
Are you the owner of the code you are sending in, or do you have permission of the owner?
y