"secure boot" not getting enabled for Chipset/Firmware Type "Q35 Chipset with UEFI SecureBoot" #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saksham-oracle
requested review from
ahadas,
ljelinkova and
smelamud
as code owners
saksham-oracle
force-pushed
the
uefi-secure-boot
branch
from
5a8d2c4
to
c8f24cf
Compare
dupondje
reviewed
Mar 14, 2024
saksham-oracle
force-pushed
the
uefi-secure-boot
branch
from
c8f24cf
to
8af62e3
Compare
|
This change seems to be an addition to #887. That PR puts a new condition here: |
sandrobonazzola
force-pushed
the
uefi-secure-boot
branch
from
8af62e3
to
b41022a
Compare
…set with UEFI SecureBoot". Issue: When VM emulator is changed to Q35 Chipset with UEFI SecureBoot from Q35 Chipset with UEFI, the NVRAM file needs to be rewritten. Fix: On VM update remove the previous NVRAM file. Signed-off-by: Saksham Srivastava <saksham.sa.srivastava@oracle.com>
sandrobonazzola
force-pushed
the
uefi-secure-boot
branch
from
b41022a
to
3d9d578
Compare
sandrobonazzola
requested review from
BrooklynDewolf
and removed request for
ljelinkova
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
When VM emulator is changed to Q35 Chipset with UEFI SecureBoot from Q35 Chipset with UEFI, the NVRAM file needs to be rewritten.
Fix:
On VM update remove the previous NVRAM file.
Signed-off-by: Saksham Srivastava saksham.sa.srivastava@oracle.com