-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable execution of CreateUserSession from GWT code #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandrobonazzola
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mwperina
force-pushed
the
ovirt-auth-bypass
branch
from
January 26, 2024 14:46
9fdab31
to
8d7ad93
Compare
/ost |
/ost basic-suite-master el9stream |
(it won't pass all the way, but el9stream should get all the way till UI tests, IIRC) |
/ost basic-suite-master el9stream |
CreateUserSesssion should be executed only as a part of login flow, so explicitly disable execution from GWT code. Signed-off-by: Martin Perina <mperina@redhat.com>
michalskrivanek
force-pushed
the
ovirt-auth-bypass
branch
from
January 30, 2024 09:37
8d7ad93
to
036f617
Compare
/ost basic-suite-master el9stream |
1 similar comment
/ost basic-suite-master el9stream |
OST passed on CS9, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CreateUserSesssion should be executed only as a part of login flow, so
explicitly disable execution from GWT code.
Signed-off-by: Martin Perina mperina@redhat.com